Feature #3719: open-uri should allow redirects from http to https

• Status: Closed
• Priority: Normal
• Assignee: akr (Akira Tanaka)
• Target version: 2.6

[hansdegraaff (Hans de Graaff)]

=begin
Currently open-uri does not allow redirects from http to https. http://redmine.ruby-lang.org/repositories/revision/1?rev=21381 reverts the ability to redirect between http and https with a note that this may compromise security, but as far as I can tell this is only true for https -> http redirects. Redirecting from http -> https should not pose such security problems and could still be allowed. This can be accomplished by allowing https for the destination URL, but not for the source URL:

• def OpenURI.redirectable?(uri1, uri2) # :nodoc:

• This test is intended to forbid a redirection from http://... to

• file:///etc/passwd.

• However this is ad hoc. It should be extensible/configurable.

• uri1.scheme.downcase == uri2.scheme.downcase ||

•  (/\A(?:http|ftp)\z/i =~ uri1.scheme && /\A(?:https?|ftp)\z/i =~ uri2.scheme)
  

• end

I'm seeing this issue with ruby 1.8.7 but the code for ruby 1.9.2 is the same.
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned
• Assignee set to akr (Akira Tanaka)

=begin

=end

[josephholsten (Joseph Holsten)]

=begin
I'm still seeing this issue. I like the way this patch works, allowing redirection from http to https but not the other way.

What needs to happen for this to be applied?
=end

[mame (Yusuke Endoh)]

• Description updated (diff)
• Target version set to 2.6

[akr (Akira Tanaka)]

• Parent task set to #859

[gary4gar (Gaurish Sharma)]

I am wondering, What's the status of this? if help is required to push this forward. I am willing to help

[cabo (Carsten Bormann)]

• Parent task deleted (#859)

With #859 fixed (thank you!), can this now be closed?

[cabo (Carsten Bormann)]

(I have no idea why I deleted the parent task, sorry about that.)

[shyouhei (Shyouhei Urabe)]

• Status changed from Assigned to Closed

OK, Closing. Thank you.