Project

General

Profile

Bug #4571

YAML.load given an ISO8601 timestamp creates an incorrect value for usec

Added by brixen (Brian Shirai) about 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
-
Backport:
[ruby-core:35713]

Description

=begin
$ ruby1.8.7 -v -ryaml -e 'p YAML.load("2011-03-22t23:32:11.000000342222+01:00").usec'
ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin9.8.0]
342222

$ ruby1.9.2 -v -ryaml -e 'p YAML.load("2011-03-22t23:32:11.000000342222+01:00").usec'
ruby 1.9.2p180 (2011-02-18 revision 30909) [i386-darwin9.8.0]
342222

$ ruby1.9 -v -ryaml -e 'p YAML.load("2011-03-22t23:32:11.000000342222+01:00").usec'
ruby 1.9.3dev (2011-04-12 trunk 31263) [i386-darwin9.8.0]
342222

I believe these should be 0.

Thanks,
Brian
=end


Files

noname (500 Bytes) noname tenderlovemaking (Aaron Patterson), 05/06/2011 08:23 AM

Updated by naruse (Yui NARUSE) about 9 years ago

  • Category set to ext
  • Status changed from Open to Assigned
  • Assignee set to tenderlovemaking (Aaron Patterson)

=begin

=end

Updated by d-snp (Tinco Andringa) about 9 years ago

I have submitted a pull request for this bug:

https://github.com/ruby/ruby/pull/15

Updated by shyouhei (Shyouhei Urabe) about 9 years ago

Hi Aaron, how do you feel the patch?

I can pull it when you are OK.

Updated by tenderlovemaking (Aaron Patterson) about 9 years ago

  • ruby -v changed from ruby 1.9.3dev (2011-04-12 trunk 31263) [i386-darwin9.8.0] to -

On Thu, May 05, 2011 at 11:31:14AM +0900, Shyouhei Urabe wrote:

Issue #4571 has been updated by Shyouhei Urabe.

Hi Aaron, how do you feel the patch?

I can pull it when you are OK.

It seems good to me. Please merge it in!

--
Aaron Patterson
http://tenderlovemaking.com/

#5

Updated by shyouhei (Shyouhei Urabe) about 9 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r31441.
Brian, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


YAML.load time correctly parse usecs smaller than 1 fixes #4571

Signed-off-by: URABE, Shyouhei shyouhei@ruby-lang.org

Also available in: Atom PDF