Backport #4679: openssl test failure on 1.9.2p204 on Windows/mingw

• Status: Rejected
• Assignee: yugui (Yuki Sonoda)

[jonforums (Jon Forums)]

While testing 1.9.2 backports on a Win7 32-bit build of ruby_1_9_2 using the RubyInstaller build recipes, the following openssl test failure occurs.

I can't replicate the failure on Win7 or Arch using trunk@31534. I will try to replicate with Arch using ruby_1_9_2 and report back if relevant. FYI, running "make test" completes without errors.

irb(main):001:0> require 'openssl'
irb(main):002:0> OpenSSL::OPENSSL_VERSION
=> "OpenSSL 1.0.0d 8 Feb 2011"

sh-3.1$ gcc --version
gcc.exe (tdm-1) 4.5.2
sh-3.1$ ruby --version
ruby 1.9.2p204 (2011-05-12 revision 31519) [i386-mingw32]
sh-3.1$ make test-all TESTS=openssl
./miniruby.exe -I../../../../Users/Jon/Documents/RubyDev/ruby-git/lib -I.ext/common -I./-
-r../../../../Users/Jon/Documents/RubyDev/ruby-git/ext/purelib.rb ../../../../Users/Jon/D
ocuments/RubyDev/ruby-git/tool/runruby.rb --extout=.ext -- "../../../../Users/Jon/Documen
ts/RubyDev/ruby-git/test/runner.rb" openssl
Loaded suite ../../../../Users/Jon/Documents/RubyDev/ruby-git/test/runner
Started
............S..............................................E..............................
..
Finished in 9.998572 seconds.

1. Skipped:
   test_freeze(OpenSSL::TestConfig) [c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/tes
   t_config.rb:6]:
   need an argument for OpenSSL::Config.new on Windows

2. Error:
   test_not_started_session(OpenSSL::TestSSL):
   Errno::EBADF: Bad file descriptor - c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/t
   est_ssl.rb
   c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/openssl/ssl-internal.rb
   :82:in fcntl' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/openssl/ssl-internal.rb :82:in initialize'
   c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in initialize' c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in new'
   c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in block in test _not_started_session' c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:164:in open'
   c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:164:in `test_not_star
   ted_session'

92 tests, 1272 assertions, 0 failures, 1 errors, 1 skips

[jonforums (Jon Forums)]

Still failing on Win7 32bit with 1.9.2p271 but not with trunk.

sh-3.1$ ruby --version
ruby 1.9.2p271 (2011-05-31 revision 31856) [i386-mingw32]
sh-3.1$ make test-all TESTS=openssl
./miniruby.exe -I../../../../Users/Jon/Documents/RubyDev/ruby-git/lib -I.ext/common -I./-
-r../../../../Users/Jon/Documents/RubyDev/ruby-git/ext/purelib.rb ../../../../Users/Jon/D
ocuments/RubyDev/ruby-git/tool/runruby.rb --extout=.ext -- "../../../../Users/Jon/Documen
ts/RubyDev/ruby-git/test/runner.rb" openssl
...SNIP...
2) Error:
test_not_started_session(OpenSSL::TestSSL):
Errno::EBADF: Bad file descriptor - c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb
c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/openssl/ssl-internal.rb:82:in fcntl' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/openssl/ssl-internal.rb:82:in initialize'
c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in initialize' c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in new'
c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:165:in block in test_not_started_session' c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:164:in open'
c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:164:in `test_not_started_session'

107 tests, 1319 assertions, 0 failures, 1 errors, 1 skips

[ko1 (Koichi Sasada)]

• Status changed from Open to Assigned
• Assignee set to nahi (Hiroshi Nakamura)

[nahi (Hiroshi Nakamura)]

• Assignee changed from nahi (Hiroshi Nakamura) to yugui (Yuki Sonoda)
• Priority changed from Normal to 3

I found that unak already covered this issue.

Index: ChangeLog

--- ChangeLog (revision 29992)
+++ ChangeLog (revision 29993)
@@ -1,3 +1,8 @@
+Wed Dec 1 15:08:32 2010 NAKAMURA Usaku [e-mail]
+

• • test/openssl/test_ssl.rb (test_not_started_session): non socket
• argument of SSLSocket.new is not supported on Windows.

Wed Dec 1 14:36:36 2010 Nobuyoshi Nakada [e-mail]

* string.c (rb_memhash): zero-filled strings should return

Index: test/openssl/test_ssl.rb

--- test/openssl/test_ssl.rb (revision 29992)
+++ test/openssl/test_ssl.rb (revision 29993)
@@ -161,6 +161,7 @@
end

 def test_not_started_session

• skip "non socket argument of SSLSocket.new is not supported on this platform" if /mswin|mingw/ =~ RUBY_PLATFORM
  open(FILE) do |f|
  assert_nil OpenSSL::SSL::SSLSocket.new(f).cert
  end

Yugui-san, please apply this to ruby_1_9_2.

[nahi (Hiroshi Nakamura)]

• Tracker changed from Bug to Backport

[naruse (Yui NARUSE)]

• Target version deleted (1.9.2)

[naruse (Yui NARUSE)]

• Project changed from 13 to 12
• Category deleted (test)

[naruse (Yui NARUSE)]

• Status changed from Assigned to Rejected