Bug #4864

RubyGems が環境変数 MAKE を見てくれない

Added by okkez _ almost 3 years ago. Updated almost 3 years ago.

[ruby-dev:43696]
Status:Closed
Priority:Normal
Assignee:Ryan Davis
Category:lib
Target version:1.9.3
ruby -v:ruby 1.9.3dev (2011-06-10 trunk 31985) [x86_64-linux] Backport:

Description

mkmf などでは環境変数 MAKE を見てくれるのですが、RubyGems だけ環境変数 MAKE を見てくれません。
RubyGems でもなぜか小文字の make は見てくれるのですが。。。
Solaris とかで gmake を使いたいときに困るので大文字の MAKE も参照するようにして欲しいです。

diff --git a/lib/rubygems/ext/builder.rb b/lib/rubygems/ext/builder.rb
index 2a147d5..8517d17 100644
--- a/lib/rubygems/ext/builder.rb
+++ b/lib/rubygems/ext/builder.rb
@@ -30,7 +30,7 @@ class Gem::Ext::Builder

 # try to find make program from Ruby configure arguments first
 RbConfig::CONFIG['configure_args'] =~ /with-make-prog\=(\w+)/
  • make_program = $1 || ENV['make']
  • makeprogram = $1 || ENV['MAKE'] || ENV['make'] unless makeprogram then makeprogram = (/mswin/ =~ RUBYPLATFORM) ? 'nmake' : 'make' end

History

#1 Updated by Yui NARUSE almost 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to Ryan Davis

#3 Updated by Hiroshi Nakamura almost 3 years ago

  • Target version changed from 1.9.2 to 1.9.3

#4 Updated by Motohiro KOSAKI almost 3 years ago

Ryan, can you please review this?

#5 Updated by Ryan Davis almost 3 years ago

  • Status changed from Assigned to Closed

Added to rubygems repo. Will migrate to core on next pull.

Also available in: Atom PDF