Project

General

Profile

Actions

Bug #4864

closed

RubyGems が環境変数 MAKE を見てくれない

Added by okkez (okkez _) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.3dev (2011-06-10 trunk 31985) [x86_64-linux]
Backport:
[ruby-dev:43696]

Description

mkmf などでは環境変数 MAKE を見てくれるのですが、RubyGems だけ環境変数 MAKE を見てくれません。
RubyGems でもなぜか小文字の make は見てくれるのですが。。。
Solaris とかで gmake を使いたいときに困るので大文字の MAKE も参照するようにして欲しいです。

diff --git a/lib/rubygems/ext/builder.rb b/lib/rubygems/ext/builder.rb
index 2a147d5..8517d17 100644
--- a/lib/rubygems/ext/builder.rb
+++ b/lib/rubygems/ext/builder.rb
@@ -30,7 +30,7 @@ class Gem::Ext::Builder

 # try to find make program from Ruby configure arguments first
 RbConfig::CONFIG['configure_args'] =~ /with-make-prog\=(\w+)/
  • make_program = $1 || ENV['make']
  • make_program = $1 || ENV['MAKE'] || ENV['make']
    unless make_program then
    make_program = (/mswin/ =~ RUBY_PLATFORM) ? 'nmake' : 'make'
    end

Updated by naruse (Yui NARUSE) over 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to zenspider (Ryan Davis)

Updated by nahi (Hiroshi Nakamura) over 11 years ago

  • Target version changed from 1.9.2 to 1.9.3

Updated by kosaki (Motohiro KOSAKI) over 11 years ago

Ryan, can you please review this?

Updated by zenspider (Ryan Davis) over 11 years ago

  • Status changed from Assigned to Closed

Added to rubygems repo. Will migrate to core on next pull.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0