Project

General

Profile

Actions

Backport #4980

closed

rbinstall.rb will not install command scripts if the path contains a hidden directory

Added by michas (Michael Schnupp) over 13 years ago. Updated over 8 years ago.

Status:
Rejected
Assignee:
-
[ruby-core:37808]

Description

I tried to compile and install ruby from a longish path containing a hidden directory somewhere in the middle of the path.

While installing the "command scripts" rbinstall.rb containts the following line:
next if //[.#]|(.(old|bak|orig|rej|diff|patch|core)|~|/core)$/i =~ src

The first part of the regex should probably only match on the basename of the file to install. But as src contains the absolute path of the file it will match all files if the path contains a hidden directory somewhere. (Which it did in my case.)

I currently pached it with a small sed-script:
sed -i 's=[.#]|=[.#][^\\\/]$|=' ruby/tool/rbinstall.rb

But the nicer solution is probably to match on the basename only.

Actions #1

Updated by nobu (Nobuyoshi Nakada) over 13 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport192

fixed by r28134.

Updated by spastorino (Santiago Pastorino) about 13 years ago

I'm hitting the same issue, installing Ruby to a .directory and in the dest bin don't have "command scripts"

Updated by drbrain (Eric Hodel) about 13 years ago

This also affects multiruby

Actions #4

Updated by naruse (Yui NARUSE) over 8 years ago

  • Status changed from Open to Rejected
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0