Feature #5373

SMTP - new method

Added by art lussos over 2 years ago. Updated about 1 year ago.

[ruby-core:39742]
Status:Closed
Priority:Normal
Assignee:Eric Hodel
Category:lib
Target version:next minor

Description

I would like to add the following method to smtp.rb command dispatcher section.

The reset command tells the mail server that the current mail transaction should be aborted.

def reset
getok('RSET')
end

net.smtp.rb.rset.patch Magnifier (1.35 KB) Eric Hodel, 05/08/2012 08:31 AM

Associated revisions

Revision 39729
Added by Eric Hodel about 1 year ago

  • lib/net/smtp.rb: Added Net::SMTP#rset method to implement the SMTP RSET command. [ruby-trunk - Feature #5373]
  • NEWS: ditto.
  • test/net/smtp/test_smtp.rb: Test for the above.

History

#1 Updated by Yusuke Endoh about 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to Minero Aoki

#2 Updated by Yusuke Endoh almost 2 years ago

  • Status changed from Assigned to Feedback

Could you please create a test?

Yusuke Endoh mame@tsg.ne.jp

#3 Updated by Eric Hodel almost 2 years ago

Here is a patch with a test, may I commit?

There aren't many net/smtp tests so perhaps there is a better way than FakeSocket.

#4 Updated by Eric Hodel almost 2 years ago

  • Status changed from Feedback to Assigned

#5 Updated by Eric Hodel almost 2 years ago

  • Category set to lib
  • Target version set to 2.0.0

May I apply this?

#6 Updated by Shugo Maeda over 1 year ago

  • Assignee changed from Minero Aoki to Yusuke Endoh

drbrain (Eric Hodel) wrote:

May I apply this?

Sasada-san told me that Aoki-san is neutral about this issue, and asked my take as a maintainer of Net::IMAP.

I think it's nice Net::SMTP to have a new method for the RSET command, but what do you think of it, Endo-san?

If permission is granted by Endo-san, there's one consideration about the method name.
The originally proposed method name is reset', but the method name in the Eric's patch isrset'.
I think `rset' is better, because other methods of Net::STMP have the same names as the SMTP command names.

#7 Updated by Eric Hodel over 1 year ago

I chose rset because it matches the other methods that follow the SMTP protocol in Net::SMTP like helo, ehlo, rcptto, mailfrom

#8 Updated by Yusuke Endoh over 1 year ago

  • Assignee changed from Yusuke Endoh to Yukihiro Matsumoto

I can't say anything but "no" because the deadline has passed.
So, don't ask me.

Yusuke Endoh mame@tsg.ne.jp

#9 Updated by Yusuke Endoh over 1 year ago

  • Target version changed from 2.0.0 to next minor

#10 Updated by Eric Hodel about 1 year ago

  • Assignee changed from Yukihiro Matsumoto to Eric Hodel

Since Aoki-san was listed as neutral last I asked, I will apply this sometime next week.

#11 Updated by Eric Hodel about 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39729.
art , thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/net/smtp.rb: Added Net::SMTP#rset method to implement the SMTP RSET command. [ruby-trunk - Feature #5373]
  • NEWS: ditto.
  • test/net/smtp/test_smtp.rb: Test for the above.

Also available in: Atom PDF