Project

General

Profile

Bug #5774

[PATCH] xmlrpc client handling cookies

Added by romanr (Roman Riha) almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 1.9.2p180 (2011-02-18) [i386-mingw32]
Backport:
[ruby-core:41711]

Description

=begin
xmlrpc client does not properly handle cookies. Firstly, they do not persist if server sets new cookies, secondly, if the server sets the same cookie more than once, the older cookies will not be overwritten.

For example this
Set-Cookie: foo=deleted
Set-Cookie: foo=bar
will set the cookie property to "foo=deleted; foo=bar", which is incorrect.

I wrote a patch, that handles both of these issues. However, the patch does not add method to delete cookies or reset the session, which might be useful.

client.rb.patch (1.2 KB) client.rb.patch romanr (Roman Riha), 12/18/2011 12:55 PM

Associated revisions

Revision 41285
Added by kou (Kouhei Sutou) over 4 years ago

  • lib/xmlrpc/client.rb (XMLRPC::Client#parse_set_cookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
  • test/xmlrpc/test_client.rb (XMLRPC::ClientTest#test_cookie_override): Add a test of the above case.

Revision 41285
Added by kou (Kouhei Sutou) over 4 years ago

  • lib/xmlrpc/client.rb (XMLRPC::Client#parse_set_cookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
  • test/xmlrpc/test_client.rb (XMLRPC::ClientTest#test_cookie_override): Add a test of the above case.

Revision 41285
Added by kou (Kouhei Sutou) over 4 years ago

  • lib/xmlrpc/client.rb (XMLRPC::Client#parse_set_cookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
  • test/xmlrpc/test_client.rb (XMLRPC::ClientTest#test_cookie_override): Add a test of the above case.

Revision 41285
Added by kou (Kouhei Sutou) over 4 years ago

  • lib/xmlrpc/client.rb (XMLRPC::Client#parse_set_cookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
  • test/xmlrpc/test_client.rb (XMLRPC::ClientTest#test_cookie_override): Add a test of the above case.

History

#1 Updated by ko1 (Koichi Sasada) over 5 years ago

  • Assignee set to nahi (Hiroshi Nakamura)

#2 Updated by shyouhei (Shyouhei Urabe) over 5 years ago

  • Status changed from Open to Assigned

#3 [ruby-core:55287] Updated by zzak (Zachary Scott) over 4 years ago

  • Assignee changed from nahi (Hiroshi Nakamura) to kou (Kouhei Sutou)

This was lib/xmlrpc/client.rb, please check it

#4 Updated by kou (Kouhei Sutou) over 4 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41285.
Roman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/xmlrpc/client.rb (XMLRPC::Client#parse_set_cookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
  • test/xmlrpc/test_client.rb (XMLRPC::ClientTest#test_cookie_override): Add a test of the above case.

Also available in: Atom PDF