[PATCH] xmlrpc client handling cookies
|ruby -v:||ruby 1.9.2p180 (2011-02-18) [i386-mingw32]||Backport:|
xmlrpc client does not properly handle cookies. Firstly, they do not persist if server sets new cookies, secondly, if the server sets the same cookie more than once, the older cookies will not be overwritten.
For example this
will set the cookie property to "foo=deleted; foo=bar", which is incorrect.
I wrote a patch, that handles both of these issues. However, the patch does not add method to delete cookies or reset the session, which might be useful.
#4 Updated by Kouhei Sutou 10 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r41285.
Roman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- lib/xmlrpc/client.rb (XMLRPC::Client#parsesetcookies): Support multiple names in a response. [Bug #5774] Reported by Roman Riha. Thanks!!!
- test/xmlrpc/testclient.rb (XMLRPC::ClientTest#testcookie_override): Add a test of the above case.