Project

General

Profile

Bug #6061

test/iconv/test_option.rb is disabled and should be enabled or removed

Added by headius (Charles Nutter) over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
trunk
Backport:
[ruby-core:42802]

Description

The only test class in test/iconv/test_option.rb is guarded by this line:

...
end if false and defined?(TestIconv)

If this test is still valid, it should be enabled. If it is not valid, it should be removed.

Updated by headius (Charles Nutter) over 8 years ago

FWIW, we (JRuby) would appreciate if whatever change is made gets backported to 1.9.3, since we're running 1.9.3 test suite as part of our normal dev process.

#2

Updated by nobu (Nobuyoshi Nakada) over 8 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34750.
Charles, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • test/iconv/test_option.rb: enabled. [ruby-core:42802][Bug #6061]

Updated by naruse (Yui NARUSE) over 8 years ago

Just FYI, implementations rescued in those tests are also valid
because those tests depends glibc iconv/GNU libiconv vendor specific extensions.

Updated by headius (Charles Nutter) over 8 years ago

Yui: Thank you. I will be adding this to our suite and excluding anything that fails. I won't worry too much about it since our iconv is implemented atop Java NIO Charset API.

Also available in: Atom PDF