Bug #6061: test/iconv/test_option.rb is disabled and should be enabled or removed

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: trunk

[headius (Charles Nutter)]

The only test class in test/iconv/test_option.rb is guarded by this line:

...
end if false and defined?(TestIconv)

If this test is still valid, it should be enabled. If it is not valid, it should be removed.

[headius (Charles Nutter)]

FWIW, we (JRuby) would appreciate if whatever change is made gets backported to 1.9.3, since we're running 1.9.3 test suite as part of our normal dev process.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r34750.
Charles, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• test/iconv/test_option.rb: enabled. [ruby-core:42802][Bug #6061]

[naruse (Yui NARUSE)]

Just FYI, implementations rescued in those tests are also valid
because those tests depends glibc iconv/GNU libiconv vendor specific extensions.

[headius (Charles Nutter)]

Yui: Thank you. I will be adding this to our suite and excluding anything that fails. I won't worry too much about it since our iconv is implemented atop Java NIO Charset API.