Project

General

Profile

Backport #6429

Backport r35631 - [mingw] Errno::EBADF in ruby/test_io.rb on ruby_1_9_3

Added by luislavena (Luis Lavena) about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:45014]

Description

Please backport r35631 to ruby_1_9_3 branch. It contains a fix for TestIO which solves misleading errors due GC'ed file descriptors.

Find attached a patch with the changes.

Thank you.


Files

backport-r35631.diff (390 Bytes) backport-r35631.diff luislavena (Luis Lavena), 05/13/2012 06:53 AM

Associated revisions

Revision e2aeaed6
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 35636,35637: [Backport #6429]

    * test/ruby/test_io.rb (TestIO): revert r35631. it broke the intent of
      test_flush_in_finalizer1.  [ruby-core:43951] [Bug ##6228]

    * test/ruby/test_io.rb (test_flush_in_finalizer1): don't use IO.for_fd
      to close IO objects. it create IO object with already closed fd, and
      cause occasional Errno::EBADF in following tests. [ruby-core:45020]
      [Bug #6228]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@35646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 35646
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 35636,35637: [Backport #6429]

* test/ruby/test_io.rb (TestIO): revert r35631. it broke the intent of
  test_flush_in_finalizer1.  [ruby-core:43951] [Bug ##6228]

* test/ruby/test_io.rb (test_flush_in_finalizer1): don't use IO.for_fd
  to close IO objects. it create IO object with already closed fd, and
  cause occasional Errno::EBADF in following tests. [ruby-core:45020]
  [Bug #6228]

History

Updated by naruse (Yui NARUSE) about 7 years ago

  • Status changed from Assigned to Closed

Backported at r35642.

Updated by akr (Akira Tanaka) about 7 years ago

2012/5/14 naruse (Yui NARUSE) naruse@airemix.jp:

Issue #6429 has been updated by naruse (Yui NARUSE).

Status changed from Assigned to Closed

Backported at r35642.

Backport #6429: Backport r35631 - [mingw] Errno::EBADF in ruby/test_io.rb on ruby_1_9_3
https://bugs.ruby-lang.org/issues/6429#change-26610

r35631 is not appropriate to backport.

See [ruby-core:45020].
--
Tanaka Akira

Also available in: Atom PDF