Bug #6930

implicit conversion warnings in vm.c

Added by Benoit Daloze over 2 years ago. Updated over 2 years ago.

[ruby-core:47310]
Status:Closed
Priority:Normal
Assignee:Koichi Sasada
ruby -v:ruby 2.0.0dev (2012-08-25 trunk 36824) [x86_64-darwin10.8.0] Backport:

Description

$ make
...
compiling vm.c
In file included from vm.c:69:
vm_insnhelper.c: In function ‘vm_setup_method’:
vm_insnhelper.c:530: warning: implicit conversion shortens 64-bit value into a 32-bit value
In file included from vm_exec.c:93,
from vm.c:71:
insns.def: In function ‘vm_exec_core’:
insns.def:841: warning: implicit conversion shortens 64-bit value into a 32-bit value
insns.def:848: warning: implicit conversion shortens 64-bit value into a 32-bit value
compiling vm_dump.c
compiling vm_backtrace.c
...

insns.def.warning.patch Magnifier (582 Bytes) Tomoyuki Chikanaga, 08/28/2012 11:54 AM

Associated revisions

Revision 36825
Added by Nobuyoshi Nakada over 2 years ago

suppress warnings

  • insns.def (checkmatch): suppress warnings. [Bug #6930]
  • vm_core.h (VM_FRAME_TYPE_FINISH_P): ditto.

Revision 36825
Added by Nobuyoshi Nakada over 2 years ago

suppress warnings

  • insns.def (checkmatch): suppress warnings. [Bug #6930]
  • vm_core.h (VM_FRAME_TYPE_FINISH_P): ditto.

Revision 36840
Added by Tomoyuki Chikanaga over 2 years ago

  • insns.def (checkmatch): suppress warnings. [Bug #6930]

Revision 36840
Added by Tomoyuki Chikanaga over 2 years ago

  • insns.def (checkmatch): suppress warnings. [Bug #6930]

Revision 36841
Added by Nobuyoshi Nakada over 2 years ago

insns.def: duplicated code

  • insns.def (checkmatch): remove duplicated code. [Bug #6930]

Revision 36841
Added by Nobuyoshi Nakada over 2 years ago

insns.def: duplicated code

  • insns.def (checkmatch): remove duplicated code. [Bug #6930]

History

#1 Updated by Nobuyoshi Nakada over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36825.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


suppress warnings

  • insns.def (checkmatch): suppress warnings. [Bug #6930]
  • vm_core.h (VM_FRAME_TYPE_FINISH_P): ditto.

#2 Updated by Tomoyuki Chikanaga over 2 years ago

There's a remaining warning on my environment (Mac OS X 10.7.4 / gcc-4.2).
I'll attach a patch. Please check it out.

#3 Updated by Nobuyoshi Nakada over 2 years ago

  • % Done changed from 100 to 50

Indeed, checkmatch_type should be moved from the `if' block.
Please commit it.

#4 Updated by Tomoyuki Chikanaga over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 50 to 100

This issue was solved with changeset r36840.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • insns.def (checkmatch): suppress warnings. [Bug #6930]

Also available in: Atom PDF