Bug #7370

Some benchmarks are slow

Added by Narihiro Nakamura over 2 years ago. Updated over 2 years ago.

[ruby-core:49410]
Status:Closed
Priority:Normal
Assignee:Aaron Patterson
ruby -v:ruby 2.0.0dev (2012-11-12 trunk 37629) [i686-linux] Backport:

Description

Hi.

Some benchmarks are slow since r37631.
I guess DTrace's proves affect CRuby's performance.
Is it possible to fix?

app_answer:
r37629 0.153(sec)
r37631 0.196

app_fib:
r37629 1.497
r37631 2.005

app_tak:
r37629 2.048
r37631 2.984

app_tarai:
r37629 1.713
r37631 2.42

app_raise:
r37629 0.792
r37631 0.85

so_ackermann:
r37629 1.809
r37631 2.529

Please see also this site: http://www.narihiro.info/crubybenci/

Thanks.

Associated revisions

Revision 37796
Added by Yui NARUSE over 2 years ago

  • vm_insnhelper.h: partly revert r37631 (DTrace support). "vm usage information is always collected, so uncomment the functions." causes performance impact. [Bug #7370] Off course this revert disables related probes.

Revision 37796
Added by Yui NARUSE over 2 years ago

  • vm_insnhelper.h: partly revert r37631 (DTrace support). "vm usage information is always collected, so uncomment the functions." causes performance impact. [Bug #7370] Off course this revert disables related probes.

Revision 37798
Added by Motohiro KOSAKI over 2 years ago

  • Makefile.in: run preprocessor when making probe.h
  • probes.d: define probe insn and insn__operand only when VM_COLLECT_USAGE_DETAILS is 1. [Bug #7370]

Revision 37798
Added by Motohiro KOSAKI over 2 years ago

  • Makefile.in: run preprocessor when making probe.h
  • probes.d: define probe insn and insn__operand only when VM_COLLECT_USAGE_DETAILS is 1. [Bug #7370]

Revision 37799
Added by Motohiro KOSAKI over 2 years ago

  • tool/gen_dummy_probes.rb: don't change #include, #if and #endif lines. [Bug #7370]

Revision 37799
Added by Motohiro KOSAKI over 2 years ago

  • tool/gen_dummy_probes.rb: don't change #include, #if and #endif lines. [Bug #7370]

History

#1 Updated by Narihiro Nakamura over 2 years ago

  • Assignee changed from Koichi Sasada to Aaron Patterson

Aaron-san, Could you check it?

Thanks.

#2 Updated by Koichi Sasada over 2 years ago

(2012/11/16 16:51), authorNari (Narihiro Nakamura) wrote:

Some benchmarks are slow since r37631.
I guess DTrace's proves affect CRuby's performance.
Is it possible to fix?

He missed to argue about the important thing:

His measurement environment is Linux and DTrace should be inactive!!

--
// SASADA Koichi at atdot dot net

#3 Updated by Yui NARUSE over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37796.
Narihiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • vm_insnhelper.h: partly revert r37631 (DTrace support). "vm usage information is always collected, so uncomment the functions." causes performance impact. [Bug #7370] Off course this revert disables related probes.

#4 Updated by Yui NARUSE over 2 years ago

  • Status changed from Closed to Assigned

#5 Updated by Motohiro KOSAKI over 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r37798.
Narihiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • Makefile.in: run preprocessor when making probe.h
  • probes.d: define probe insn and insn__operand only when VM_COLLECT_USAGE_DETAILS is 1. [Bug #7370]

Also available in: Atom PDF