Bug #8315

mkmf does not include include paths from pkg_config anymore

Added by Hans Mackowiak over 2 years ago. Updated 11 months ago.

[ruby-core:54532]
Status:Closed
Priority:Normal
Assignee:Nobuyoshi Nakada
ruby -v:trunk Backport:2.0.0: DONE, 2.1: DONE

Description

#6504 does that, for cpp files $CFLAGS is not used anymore, so the problems are the include paths:

  • there is no $CXXFLAGS global variable defined
  • pkg_config does not add the includes paths to the correct *FLAGS

so my gems are currently broken for ruby trunk and if i fix that it may be broken for the older ruby


Related issues

Related to Backport200 - Backport #6504: mkmf.rb should not use CFLAGS when compiling C++ code Closed 05/27/2012

Associated revisions

Revision 47457
Added by Nobuyoshi Nakada 11 months ago

mkmf.rb: --cflags to $CXXFLAGS

  • lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also $CXXFLAGS, as they are often used by C++ compiler. [Bug #8315]

Revision 47457
Added by Nobuyoshi Nakada 11 months ago

mkmf.rb: --cflags to $CXXFLAGS

  • lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also $CXXFLAGS, as they are often used by C++ compiler. [Bug #8315]

Revision 47587
Added by Tomoyuki Chikanaga 11 months ago

merge revision(s) r47457: [Backport #8315]

* lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also
  $CXXFLAGS, as they are often used by C++ compiler.
   [Bug #8315]

Revision 47592
Added by Tomoyuki Chikanaga 11 months ago

merge revision(s) r44459,r44470: [Backport #8315]

* lib/mkmf.rb (configuration): Make CXXFLAGS customizable.
  Patch by Kohei Suzuki (eagletmt). [Fixes GH-492]

Revision 47609
Added by Usaku NAKAMURA 11 months ago

merge revision(s) 44459,44470,47457: [Backport #8315]

* lib/mkmf.rb (configuration): Make CXXFLAGS customizable.
  Patch by Kohei Suzuki (eagletmt). [Fixes GH-492]

* lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also
  $CXXFLAGS, as they are often used by C++ compiler.
   [Bug #8315]

History

#1 Updated by Hans Mackowiak over 2 years ago

ups i assiged it to the wrong nobu, can someone change that?

#2 Updated by Nobuyoshi Nakada over 2 years ago

  • Assignee changed from Nobuhiro Iwamatsu to Nobuyoshi Nakada

#3 Updated by Hans Mackowiak 11 months ago

have somone time to fix that?
currently it still does needed to fix it by myself to get the gems working

#4 Updated by Nobuyoshi Nakada 11 months ago

  • Description updated (diff)

#5 Updated by Nobuyoshi Nakada 11 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r47457.


mkmf.rb: --cflags to $CXXFLAGS

  • lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also $CXXFLAGS, as they are often used by C++ compiler. [Bug #8315]

#6 Updated by Tomoyuki Chikanaga 11 months ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED

#7 Updated by Tomoyuki Chikanaga 11 months ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

Backported into ruby_2_1 branch at r47587.

#8 Updated by Tomoyuki Chikanaga 11 months ago

  • Related to Backport #6504: mkmf.rb should not use CFLAGS when compiling C++ code added

#9 Updated by Tomoyuki Chikanaga 11 months ago

Sorry, r47587 breaks build of digests/*.

I overlooked r44459 and r44460 because they seems a new feature (and there's no ticket for these commits).
But I think r44459 is rather a bug fix for degrade introduced by r39994.
I additionally backported r44459 and r44470 to check if they fix build error on RubyCI.

usa san, how do you think? ruby_2_0_0 includes r39994 too.

#10 Updated by Usaku NAKAMURA 11 months ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

backported into ruby_2_0_0 at r47609.

nagachika san:
I think that r44459 (and r44470) is a bug fix (lack of specification or implementation).
Thank you for information.

Also available in: Atom PDF