Bug #8769

[PATCH] process.c (rb_fork_internal): remove cloexec setting

Added by Eric Wong 9 months ago. Updated 7 months ago.

[ruby-core:56523]
Status:Closed
Priority:Low
Assignee:Nobuyoshi Nakada
Category:core
Target version:2.1.0
ruby -v:ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux] Backport:1.9.3: DONTNEED, 2.0.0: DONE

Description

The close-on-exec flag is already set via:
pipenocrash -> rbpipe -> rbcloexecpipe
Calling fcntl here is redundant.

0001-process.c-rb_fork_internal-remove-cloexec-setting.patch Magnifier (917 Bytes) Eric Wong, 08/11/2013 05:49 AM

Associated revisions

Revision 43008
Added by Nobuyoshi Nakada 7 months ago

process.c: remove cloexec setting

  • process.c (rbforkinternal): remove cloexec setting on pipes created by rbcloexecpipe. patch by normalperson (Eric Wong) at . [Bug #8769]

History

#1 Updated by Nobuyoshi Nakada 9 months ago

Seems reasonable.

#2 Updated by Yui NARUSE 7 months ago

  • Status changed from Open to Assigned
  • Assignee set to Nobuyoshi Nakada

nobu, could you commit this?

#3 Updated by Nobuyoshi Nakada 7 months ago

Eric can't?

#4 Updated by Eric Wong 7 months ago

"nobu (Nobuyoshi Nakada)" nobu@ruby-lang.org wrote:

Eric can't?

I never accepted commit bit to any project in years. I'm not
trustworthy/sane enough nor do I want to feel obligated to Ruby.

It should be easier to accept patches from drive-by contributors such as
myself, though. IMHO, maintaining ChangeLog in repository makes
applying/merging patches harder (vs using commit message + generated
changelog in dist tarball).

#5 Updated by Nobuyoshi Nakada 7 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43008.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


process.c: remove cloexec setting

  • process.c (rbforkinternal): remove cloexec setting on pipes created by rbcloexecpipe. patch by normalperson (Eric Wong) at . [Bug #8769]

#6 Updated by Nobuyoshi Nakada 7 months ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: REQUIRED

#7 Updated by Tomoyuki Chikanaga 7 months ago

  • Backport changed from 1.9.3: DONTNEED, 2.0.0: REQUIRED to 1.9.3: DONTNEED, 2.0.0: DONE

backported to ruby20_0 at r43227.

Also available in: Atom PDF