Project

General

Profile

Actions

Bug #8769

closed

[PATCH] process.c (rb_fork_internal): remove cloexec setting

Added by normalperson (Eric Wong) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux]
[ruby-core:56523]

Description

The close-on-exec flag is already set via:
pipe_nocrash -> rb_pipe -> rb_cloexec_pipe
Calling fcntl here is redundant.


Files

Updated by nobu (Nobuyoshi Nakada) over 10 years ago

Seems reasonable.

Updated by naruse (Yui NARUSE) over 10 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

nobu, could you commit this?

Updated by normalperson (Eric Wong) over 10 years ago

"nobu (Nobuyoshi Nakada)" wrote:

Eric can't?

I never accepted commit bit to any project in years. I'm not
trustworthy/sane enough nor do I want to feel obligated to Ruby.

It should be easier to accept patches from drive-by contributors such as
myself, though. IMHO, maintaining ChangeLog in repository makes
applying/merging patches harder (vs using commit message + generated
changelog in dist tarball).

Actions #5

Updated by nobu (Nobuyoshi Nakada) over 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43008.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


process.c: remove cloexec setting

  • process.c (rb_fork_internal): remove cloexec setting on pipes
    created by rb_cloexec_pipe. patch by normalperson (Eric Wong) at
    [ruby-core:56523]. [Bug #8769]

Updated by nobu (Nobuyoshi Nakada) over 10 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 10 years ago

  • Backport changed from 1.9.3: DONTNEED, 2.0.0: REQUIRED to 1.9.3: DONTNEED, 2.0.0: DONE

backported to ruby_2_0_0 at r43227.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0