[PATCH] process.c (rb_fork_internal): remove cloexec setting
|ruby -v:||ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux]||Backport:||1.9.3: DONTNEED, 2.0.0: DONE|
The close-on-exec flag is already set via:
pipenocrash -> rbpipe -> rbcloexecpipe
Calling fcntl here is redundant.
"nobu (Nobuyoshi Nakada)" firstname.lastname@example.org wrote:
I never accepted commit bit to any project in years. I'm not
trustworthy/sane enough nor do I want to feel obligated to Ruby.
It should be easier to accept patches from drive-by contributors such as
myself, though. IMHO, maintaining ChangeLog in repository makes
applying/merging patches harder (vs using commit message + generated
changelog in dist tarball).
#5 Updated by Nobuyoshi Nakada 7 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r43008.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
process.c: remove cloexec setting
- process.c (rbforkinternal): remove cloexec setting on pipes created by rbcloexecpipe. patch by normalperson (Eric Wong) at . [Bug #8769]