Bug #8841: Module#included_modules and prepended modules

• Status: Closed
• Assignee: matz (Yukihiro Matsumoto)
• Target version: -
• ruby -v: r42735
• Tags: notbug, doc

[marcandre (Marc-Andre Lafortune)]

The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with include? that returns true for prepended modules, but not quite consistent with included that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of include? and included_modules.

[naruse (Yui NARUSE)]

• Target version deleted (2.6)

[mame (Yusuke Endoh)]

Summary:

• Module#include? and Module#included_modules regard prepended modules as included (not well documented)
• Module#included is not called when the module is prepended

Is this right?

[byroot (Jean Boussier)]

Module#included is not called when the module is prepended

I think that's fine, because it calls Module#prepended.

Module#include? and Module#included_modules regard prepended modules as included (not well documented)

That yes:

class Base
end

module A
end

module B
end

Base.prepend(A)
Base.include(B)

p Base.included_modules

outputs:

[A, B, Kernel]

[matz (Yukihiro Matsumoto)]

• Status changed from Open to Closed

This intentional.

Matz.

[marcandre (Marc-Andre Lafortune)]

Thank you.

I clarified the documentation to reflect this.