Actions
Feature #8919
closedQueue as embedded class
Description
Queue class in lib/thread.rb (ext/thread/thread.c from Ruby 2.1) is easy and safe way to communicate between threads.
How about to include Queue class as embedded class to elaborate using Queue?
This proposal is not include ConditionVariable and SizedQueue.
Files
Updated by ko1 (Koichi Sasada) almost 11 years ago
Matz, how about it?
(no compatibility issue, we have an implementation)
Updated by hsbt (Hiroshi SHIBATA) over 10 years ago
- Target version changed from 2.1.0 to 2.2.0
Updated by matz (Yukihiro Matsumoto) over 10 years ago
It's OK for 2.2.
Matz.
Updated by hsbt (Hiroshi SHIBATA) about 10 years ago
- Status changed from Open to Assigned
- Assignee changed from matz (Yukihiro Matsumoto) to ko1 (Koichi Sasada)
Updated by Glass_saga (Masaki Matsushita) almost 10 years ago
- File patch.diff patch.diff added
How about the implementation in attached patch.diff?
Updated by ko1 (Koichi Sasada) almost 10 years ago
Now, thread.rb is required from rubygems.
$ ./ruby -ve 'p Queue'
ruby 2.2.0dev (2014-11-20 trunk 48507) [x86_64-linux]
Thread::Queue
and
$ ./ruby --disable-gems -ve 'p Queue'
ruby 2.2.0dev (2014-11-20 trunk 48507) [x86_64-linux]
-e:1:in `<main>': uninitialized constant Queue (NameError)
What should we do?
Updated by nobu (Nobuyoshi Nakada) almost 10 years ago
By adding a line thread
to ext/Setup file, thread.so can be statically linked to ruby (or libruby) now.
Updated by ko1 (Koichi Sasada) about 9 years ago
- Status changed from Assigned to Closed
Applied in changeset r51660.
- ext/thread/thread.c: move definitions of Queue, SizedQueue
and ConditionalVariables to thread_tools.c. In other wowrds,
such classes are built-in.
[Feature #8919]
At first, I planned to embed only a Queue class.
However, rubygems requires 'thread.rb' (rubygems are
required at first, when launch MRI without --disable-gems).
So most of people require 'thread.rb' as an embedded library.
Now, ext/thread/thread.c is empty, only for a dummy for
compatibility. - thread.c: move a definition of Mutex class to thread_tools.c.
And define Mutex class under Thread (so now Mutex is Thread::Mutex).
Because other thread related classes are also defined under Thread.
We remain ::Mutex as Thread::Mutex. Only an inspect result is changed. - common.mk: add dependency from thread.o to thraed_tools.c.
Actions
Like0
Like0Like0Like0Like0Like0Like0Like0Like0