Bug #9046
[PATCH] Inter-process locking for log rotation is required
Description
I sent a pull request on https://github.com/ruby/ruby/pull/428 . Please see details on it.
Related issues
Associated revisions
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
logger.rb: fix r43511 for Windows
- lib/logger.rb (Logger::LogDevice::LogDeviceMutex#lock_shift_log): open file can't be removed or renamed on Windows. [Bug #9046]
- test/logger/test_logger.rb (TestLogDevice#run_children): don't use fork.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43513 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
History
#1
[ruby-dev:47770]
Updated by shyouhei (Shyouhei Urabe) over 4 years ago
- Description updated (diff)
#2
[ruby-dev:47771]
Updated by naruse (Yui NARUSE) over 4 years ago
The point "current implementation is wrong on multi-process environment" sounds reasonable and need to fix.
I commented some implementation points to the pull request.
#3
Updated by naruse (Yui NARUSE) over 4 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r43511.
Naotoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- lib/logger.rb: Inter-process locking for log rotation Current implementation fails log rotation on multi process env. by sonots sonots@gmail.com https://github.com/ruby/ruby/pull/428 fix GH-428 [Bug #9046]
#4
[ruby-dev:47790]
Updated by nobu (Nobuyoshi Nakada) over 4 years ago
- Status changed from Closed to Open
- Priority changed from Normal to 5
- % Done changed from 100 to 0
=begin
It broke on Windows.
- don't use fork.
- don't assume that open file can be removed or renamed.
I'll try to fix or revert it.
=end
#5
Updated by nobu (Nobuyoshi Nakada) over 4 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r43513.
Naotoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
logger.rb: fix r43511 for Windows
- lib/logger.rb (Logger::LogDevice::LogDeviceMutex#lock_shift_log): open file can't be removed or renamed on Windows. [Bug #9046]
- test/logger/test_logger.rb (TestLogDevice#run_children): don't use fork.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e