Bug #9186

json/pure.rb missing on trunk

Added by Charlie Somerville 5 months ago. Updated 3 months ago.

[ruby-core:58724]
Status:Rejected
Priority:High
Assignee:Yui NARUSE
Category:-
Target version:2.1.0
ruby -v:ruby 2.1.0dev (2013-11-30 trunk 43927) [x86_64-darwin13.0] Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

Line 60 of ext/json/lib/json.rb requires json/pure if json/ext cannot be required.

This file is missing on trunk, meaning the JSON library is broken unless the C extension is present.

History

#1 Updated by Hiroshi SHIBATA 5 months ago

  • Assignee set to Yui NARUSE
  • Target version set to 2.1.0

#2 Updated by Vit Ondruch 5 months ago

I'm just wondering, what should be the circumstances that C extension is missing?

#3 Updated by Charlie Somerville 5 months ago

@vo.x: I noticed this because it was breaking on Rubinius - there's also probably some situations where C extensions can't be loaded in CRuby.

#4 Updated by Motohiro KOSAKI 5 months ago

there's also probably some situations where C extensions can't be loaded in CRuby.

Hmm.. When? It shouldn't happen on CRuby.

#5 Updated by Charlie Somerville 5 months ago

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

#6 Updated by Motohiro KOSAKI 5 months ago

2013/12/1 charliesome (Charlie Somerville) charliesome@ruby-lang.org:

Issue #9186 has been updated by charliesome (Charlie Somerville).

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

Can you please elaborate more? Do you mean JSON is now cross-compile
unsafe? It seems horrible.

#7 Updated by Charlie Somerville 5 months ago

Can you please elaborate more? Do you mean JSON is now cross-compile unsafe? It seems horrible.

This was a long time ago, and I can't recall specific details. I was just using this as an example of when C extensions may not work properly and this bug could be triggered in CRuby.

#8 Updated by Yui NARUSE 3 months ago

  • Status changed from Open to Rejected

I intentionally removed pure.rb on ruby's repo because CRuby always have C exts.

If C exts is not properly build, the binary shouldn't work.

Also available in: Atom PDF