Project

General

Profile

Bug #9186

json/pure.rb missing on trunk

Added by Charlie Somerville over 2 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
ruby -v:
ruby 2.1.0dev (2013-11-30 trunk 43927) [x86_64-darwin13.0]
[ruby-core:58724]

Description

Line 60 of ext/json/lib/json.rb requires json/pure if json/ext cannot be required.

This file is missing on trunk, meaning the JSON library is broken unless the C extension is present.

History

#1 [ruby-core:58734] Updated by Hiroshi SHIBATA over 2 years ago

  • Assignee set to Yui NARUSE
  • Target version set to 2.1.0

#2 [ruby-core:58749] Updated by Vit Ondruch over 2 years ago

I'm just wondering, what should be the circumstances that C extension is missing?

#3 [ruby-core:58751] Updated by Charlie Somerville over 2 years ago

@vo.x: I noticed this because it was breaking on Rubinius - there's also probably some situations where C extensions can't be loaded in CRuby.

#4 [ruby-core:58754] Updated by Motohiro KOSAKI over 2 years ago

there's also probably some situations where C extensions can't be loaded in CRuby.

Hmm.. When? It shouldn't happen on CRuby.

#5 [ruby-core:58758] Updated by Charlie Somerville over 2 years ago

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

#6 [ruby-core:58762] Updated by Motohiro KOSAKI over 2 years ago

2013/12/1 charliesome (Charlie Somerville) charliesome@ruby-lang.org:

Issue #9186 has been updated by charliesome (Charlie Somerville).

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

Can you please elaborate more? Do you mean JSON is now cross-compile
unsafe? It seems horrible.

#7 [ruby-core:58767] Updated by Charlie Somerville over 2 years ago

Can you please elaborate more? Do you mean JSON is now cross-compile unsafe? It seems horrible.

This was a long time ago, and I can't recall specific details. I was just using this as an example of when C extensions may not work properly and this bug could be triggered in CRuby.

#8 [ruby-core:59658] Updated by Yui NARUSE over 2 years ago

  • Status changed from Open to Rejected

I intentionally removed pure.rb on ruby's repo because CRuby always have C exts.

If C exts is not properly build, the binary shouldn't work.

Also available in: Atom PDF