Bug #9213

mkmf.rb emits invalid destination directory name for mswin32/64

Added by Akio Tajima over 1 year ago. Updated about 1 year ago.

[ruby-core:58856]
Status:Assigned
Priority:Normal
Assignee:Nobuyoshi Nakada
ruby -v:ruby 2.0.0p353 (2013-11-22) [i386-mswin32_100] Backport:1.9.3: UNKNOWN, 2.0.0: DONE

Description

The install process of traditional extended library (=non gem) uses extconf.rb for creating Makefile and install the library by (n)make install.
However it does not work correctly because of FileUtil.mkdir met bad directory name as 'c:c:/...'.

This is caused by DESTDIR and prefix combination.
When one does not specify DESTDIR, rbconfig.rb create it as 'DESTDIR = TOPDIR && TOPDIR[/\A[a-z]:/i] || '' unless defined? DESTDIR' #=> 'C:' or 'D:'.
By the other hand CONFIG['prefix'] is (TOPDIR || DESTDIR + '/usr') so the prefixdir also contains 'c:' or 'd:' ...

The definition for install directories in mkmf.rb is defined as both DESTDIR and CONFIG['prefix'] directory for example '$(DESTDIR)$(vendorarchdir)$(target_prefix)'.
It causes the double drive letter name 'c:c:...'.

While there are some workarounds as using setup.rb or gem, it's harmful for the testing phase of extended libraries.

Associated revisions

Revision 44019
Added by Nobuyoshi Nakada over 1 year ago

mkmf.rb: strip destdir from prefix

  • lib/mkmf.rb (configuration): strip destdir part from prefix to get rid of duplication. a patch by arton at . [Bug #9213]

Revision 44019
Added by Nobuyoshi Nakada over 1 year ago

mkmf.rb: strip destdir from prefix

  • lib/mkmf.rb (configuration): strip destdir part from prefix to get rid of duplication. a patch by arton at . [Bug #9213]

History

#1 Updated by Akio Tajima over 1 year ago

I think the DESTDIR setting is for DOS like prefix.
So this is the patch.

--- mkmf.rb.org 2013-12-05 02:38:38.508908700 +0900
+++ mkmf.rb 2013-12-05 02:38:59.788774499 +0900
@@ -1849,6 +1849,7 @@ VPATH = #{vpath.join(CONFIG['PATH_SEPARA
     prefix = mkintpath(CONFIG["prefix"])
     if destdir = prefix[$dest_prefix_pattern, 1]
       mk << "\nDESTDIR = #{destdir}\n"
+      prefix = prefix[destdir.size..-1]
     end
     mk << "prefix = #{with_destdir(prefix).unspace}\n"
     CONFIG.each do |key, var|

#2 Updated by Nobuyoshi Nakada over 1 year ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44019.
Akio, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


mkmf.rb: strip destdir from prefix

  • lib/mkmf.rb (configuration): strip destdir part from prefix to get rid of duplication. a patch by arton at . [Bug #9213]

#3 Updated by Tomoyuki Chikanaga over 1 year ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: UNKNOWN, 2.0.0: REQUIRED

#4 Updated by Tomoyuki Chikanaga over 1 year ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: REQUIRED to 1.9.3: UNKNOWN, 2.0.0: DONE

r44019 was backported to ruby_2_0_0 at r44367.

#5 Updated by Masahiro Kitajima about 1 year ago

副作用の報告です。

Sample code

sample.c

void Init_Sample() {
}

extconf.rb

require "mkmf"
create_makefile("Sample")

Operation

    C:\TMP>ruby -v
 1: ruby 2.0.0p451 (2014-02-24) [i386-mswin32]
    C:\TMP>ruby extconf.rb
 1: creating Makefile
    C:\TMP>nmake /N
 1: 
 2: Microsoft (R) Program Maintenance Utility   Version 6.00.9782.0
 3: Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
 4: 
 5:     echo generating Sample-i386-mswin32.def
 6:      \ruby200\bin\ruby -e "puts 'EXPORTS', 'Init_Sample'"  > Sample-i386-mswin32.def
 7:     echo compiling sample.c
 8:      cl -nologo -I. -Ic:/ruby200/include/ruby-2.0.0/i386-mswin32 -Ic:/ruby200/include/ruby-2.0.0/ruby/backward -Ic:/ruby200/include/ruby-2.0.0 -I.  -MD -Zi -W2 -O2b2xg- -G6 -Zm600   -Fosample.obj -c -Tcsample.c
 9:     echo linking shared-object Sample.so
10:     \ruby200\bin\ruby -run -e rm -- -f Sample.so
11:      cl -nologo -LD -FeSample.so sample.obj msvcrt-ruby200.lib  oldnames.lib user32.lib advapi32.lib shell32.lib ws2_32.lib imagehlp.lib shlwapi.lib  -link -incremental:no -debug -opt:ref -opt:icf -incremental:no -debug -opt:ref -opt:icf -dll -libpath:. -libpath:/ruby200/lib  -implib:Sample-i386-mswin32.lib -pdb:Sample-i386-mswin32.pdb -def:Sample-i386-mswin32.def

6行目と 10行目、$(RUBY) の展開結果にドライブ名が付いていません。

#6 Updated by Nobuyoshi Nakada about 1 year ago

  • Target version changed from 2.1.0 to current: 2.2.0
  • Assignee set to Nobuyoshi Nakada
  • Status changed from Closed to Assigned

memo: 2.0.0 has not backported r41648 and r41756.

Also available in: Atom PDF