Bug #9338

Build failure of trunk with MSVC 2013

Added by Heesob Park 4 months ago. Updated 2 months ago.

[ruby-core:59451]
Status:Closed
Priority:Normal
Assignee:-
Category:-
Target version:-
ruby -v:ruby-2.2.0-r44473 Backport:1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: DONTNEED

Description

The revision r44473 introduced the following error.

compiling eval.c
eval.c
eval.c(558) : error C4028: formal parameter 3 different from declaration
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\BIN\x86_amd64\cl.EXE"' : return code '0x2'
Stop.

You can see this issue also in http://rubyci.org (http://ruby-mswin.cloudapp.net/vc10-x64/ruby-trunk/log/20131231T144935Z.log.html.gz)

Here is patch

diff --git a/eval.c b/eval.c
index 783aa33..b3c4100 100644
--- a/eval.c
+++ b/eval.c
@@ -554,7 +554,7 @@ setupexception(rbthread_t *th, int tag, volatile VALUE mesg, VALUE cause)
}

static void
-rblongjmp(int tag, volatile VALUE mesg, VALUE cause)
+rb
longjmp(int tag, volatile VALUE mesg, volatile VALUE cause)
{
rbthreadt *th = GETTHREAD();
setup
exception(th, tag, mesg, cause);


Related issues

Related to CommonRuby - Feature #8257: Exception#cause to carry originating exception along with... Open 04/12/2013

Associated revisions

Revision 44483
Added by Nobuyoshi Nakada 4 months ago

eval.c: extra modifier

  • eval.c (rb_longjmp): remove an extra modifier from the forward declaration to match the actual definition. [Bug #9338]

History

#1 Updated by Nobuyoshi Nakada 4 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44483.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


eval.c: extra modifier

  • eval.c (rb_longjmp): remove an extra modifier from the forward declaration to match the actual definition. [Bug #9338]

#2 Updated by Usaku NAKAMURA 2 months ago

  • Related to Feature #8257: Exception#cause to carry originating exception along with new one added

#3 Updated by Usaku NAKAMURA 2 months ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: DONTNEED

Also available in: Atom PDF