Bug #9455: Blocks do not round-trip properly through ISeq dump/load

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: trunk
• Backport: 1.9.3: DONTNEED, 2.0.0: DONE, 2.1: DONE

Blocks passed to methods do not round-trip properly when dumped with RubyVM::InstructionSequence#to_a and then loaded again with rb_iseq_load.

This is because iseq_data_to_ary in iseq.c stores serialized blocks under the :blockptr key (https://github.com/ruby/ruby/blob/trunk/iseq.c#L1813), but expects them to be stored in the :block key when loading them back up (https://github.com/ruby/ruby/blob/trunk/compile.c#L5811).

This affects trunk, 2.1.0 and 2.0.0.

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r44720.

---

compile.c: use correct key for block when loading serialized iseqs

• compile.c (iseq_build_from_ary_body): Use :blockptr instead of :block
  as hash key when loading serialized instruction sequences from arrays.
  [Bug #9455] [ruby-core:60146]

[naruse (Yui NARUSE)]

• Backport changed from 1.9.3: DONTNEED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONTNEED, 2.0.0: REQUIRED, 2.1: DONE

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: DONTNEED, 2.0.0: REQUIRED, 2.1: DONE to 1.9.3: DONTNEED, 2.0.0: DONE, 2.1: DONE

r44720 was backported to ruby_2_0_0 at r45106.

[wanabe (_ wanabe)]

• Has duplicate Bug #7995: RubyVM::InstructionSequence to_a not working for blocks added