Project

General

Profile

Feature #9469

BigDecimal support for yaml serialization

Added by zzak (Zachary Scott) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:60402]

Description

Given the following serialization methods in rails/rails: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/big_decimal/conversions.rb

I feel like these methods would be better supported in the upstream BigDecimal gem.

How do you feel like adding them mrkn (Kenta Murata)?

History

#1 [ruby-core:60403] Updated by zzak (Zachary Scott) over 3 years ago

  • Tracker changed from Bug to Feature

#2 [ruby-core:60406] Updated by nobu (Nobuyoshi Nakada) over 3 years ago

  • Assignee changed from zzak (Zachary Scott) to mrkn (Kenta Murata)

Why changing the default format?
And it doesn't seem round-trip.

#3 [ruby-core:60411] Updated by rafaelfranca (Rafael Fran├ža) over 3 years ago

I think we can remove that custom yaml serialization from Rails and we don't need to put in upstream.

Looking in the history of that file I found it was added 6 years ago because at that date BigDecimal doesn't support to_yaml.

Since we already support it we can remove without any problem.

#4 [ruby-core:60630] Updated by zzak (Zachary Scott) over 3 years ago

  • Status changed from Assigned to Closed

Also available in: Atom PDF