Feature #9469

BigDecimal support for yaml serialization

Added by Zachary Scott over 1 year ago. Updated about 1 year ago.

[ruby-core:60402]
Status:Closed
Priority:Normal
Assignee:Kenta Murata

Description

Given the following serialization methods in rails/rails: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/big_decimal/conversions.rb

I feel like these methods would be better supported in the upstream BigDecimal gem.

How do you feel like adding them @mrkn?

History

#1 Updated by Zachary Scott over 1 year ago

  • Tracker changed from Bug to Feature

#2 Updated by Nobuyoshi Nakada over 1 year ago

  • Assignee changed from Zachary Scott to Kenta Murata

Why changing the default format?
And it doesn't seem round-trip.

#3 Updated by Rafael França over 1 year ago

I think we can remove that custom yaml serialization from Rails and we don't need to put in upstream.

Looking in the history of that file I found it was added 6 years ago because at that date BigDecimal doesn't support to_yaml.

Since we already support it we can remove without any problem.

#4 Updated by Zachary Scott about 1 year ago

  • Status changed from Assigned to Closed

Also available in: Atom PDF