Project

General

Profile

Actions

Feature #9469

closed

BigDecimal support for yaml serialization

Added by zzak (zzak _) about 10 years ago. Updated about 10 years ago.

Status:
Closed
Target version:
[ruby-core:60402]

Description

Given the following serialization methods in rails/rails: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/big_decimal/conversions.rb

I feel like these methods would be better supported in the upstream BigDecimal gem.

How do you feel like adding them @mrkn (Kenta Murata)?

Updated by zzak (zzak _) about 10 years ago

  • Tracker changed from Bug to Feature

Updated by nobu (Nobuyoshi Nakada) about 10 years ago

  • Assignee changed from zzak (zzak _) to mrkn (Kenta Murata)

Why changing the default format?
And it doesn't seem round-trip.

Updated by rafaelfranca (Rafael França) about 10 years ago

I think we can remove that custom yaml serialization from Rails and we don't need to put in upstream.

Looking in the history of that file I found it was added 6 years ago because at that date BigDecimal doesn't support to_yaml.

Since we already support it we can remove without any problem.

Updated by zzak (zzak _) about 10 years ago

  • Status changed from Assigned to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0