Bug #9483

Fix typo in OpenURI and Ripper documenation

Added by Jonathan Jackson over 1 year ago. Updated over 1 year ago.

[ruby-core:60457]
Status:Closed
Priority:Normal
Assignee:Zachary Scott
ruby -v:2.2.0 Backport:1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

Description

Fixed grammar error in OpenURI#content_encoding and Ripper#tokenize.

Grouped them together because both were the same typo.

0001-Fix-grammar-error-in-OpenURI-content_encoding-and-Ri.patch Magnifier (1.26 KB) Jonathan Jackson, 02/05/2014 01:07 AM

Associated revisions

Revision 44878
Added by Zachary Scott over 1 year ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44878
Added by Zachary Scott over 1 year ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44879
Added by Zachary Scott over 1 year ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

Revision 44879
Added by Zachary Scott over 1 year ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

History

#1 Updated by Zachary Scott over 1 year ago

  • Assignee changed from Eric Hodel to Zachary Scott
  • Status changed from Open to Assigned

Thanks for the patch, yeah the grammar sounds weird but I think what the author wanted to represent as the actual type of these return values. Hence the capital Array and String, but it makes more sense to just lower case these and move on.

I'll commit a patch soon.

#2 Updated by Zachary Scott over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

Applied in changeset r44878.


  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

#3 Updated by Usaku NAKAMURA over 1 year ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

#4 Updated by Tomoyuki Chikanaga over 1 year ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED

r44878 and r44879 were backported to ruby_2_0_0 at r44985.

#5 Updated by Yui NARUSE over 1 year ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE

r45116

#6 Updated by Usaku NAKAMURA over 1 year ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

backported into ruby_1_9_3 at r45158.

Also available in: Atom PDF