Project

General

Profile

Bug #9483

Fix typo in OpenURI and Ripper documenation

Added by rondale_sc (Jonathan Jackson) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:60457]

Description

Fixed grammar error in OpenURI#content_encoding and Ripper#tokenize.

Grouped them together because both were the same typo.

Associated revisions

Revision 44878
Added by zzak (Zachary Scott) over 3 years ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44878
Added by zzak (Zachary Scott) over 3 years ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44878
Added by zzak (Zachary Scott) over 3 years ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44878
Added by zzak (Zachary Scott) over 3 years ago

  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

Revision 44879
Added by zzak (Zachary Scott) over 3 years ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

Revision 44879
Added by zzak (Zachary Scott) over 3 years ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

Revision 44879
Added by zzak (Zachary Scott) over 3 years ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

Revision 44879
Added by zzak (Zachary Scott) over 3 years ago

  • lib/open-uri.rb: [DOC] use lower case version of core classes, same as commit r44878, based on patch by Jonathan Jackson [Bug #9483] [ci skip]

History

#1 [ruby-core:60458] Updated by zzak (Zachary Scott) over 3 years ago

  • Status changed from Open to Assigned
  • Assignee changed from drbrain (Eric Hodel) to zzak (Zachary Scott)

Thanks for the patch, yeah the grammar sounds weird but I think what the author wanted to represent as the actual type of these return values. Hence the capital Array and String, but it makes more sense to just lower case these and move on.

I'll commit a patch soon.

#2 [ruby-core:60559] Updated by zzak (Zachary Scott) over 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44878.


  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core classes when referring to return value, since we aren't directly talking about the class. Patch by Jonathan Jackson [Bug #9483]

#3 [ruby-core:60693] Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

#4 [ruby-core:60772] Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED

r44878 and r44879 were backported to ruby_2_0_0 at r44985.

#5 [ruby-core:60983] Updated by naruse (Yui NARUSE) over 3 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE

r45116

#6 [ruby-core:61042] Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

backported into ruby_1_9_3 at r45158.

Also available in: Atom PDF