Feature #9532

Expose logger monitor

Added by Arthur Neves over 1 year ago. Updated 11 months ago.

[ruby-core:60837]
Status:Feedback
Priority:Normal
Assignee:Hiroshi Nakamura

Description

I was wondering if we could do this type of change on the logger class:

https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f

I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.

History

#1 Updated by Zachary Scott over 1 year ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to Narihiro Nakamura
  • Target version set to current: 2.2.0

Please note: a number of libraries are using this class: https://github.com/search?l=ruby&q=LogDeviceMutex&ref=cmdform&type=Code

#2 Updated by Hiroshi SHIBATA over 1 year ago

  • Assignee changed from Narihiro Nakamura to Hiroshi Nakamura

#3 Updated by Hiroshi SHIBATA 11 months ago

  • Status changed from Assigned to Feedback

Your patch broke logger and syslog/logger tests.

Also available in: Atom PDF