Actions
Feature #9532
closedExpose logger monitor
Description
I was wondering if we could do this type of change on the logger class:
https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f
I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.
Updated by zzak (zzak _) over 10 years ago
- Category set to lib
- Status changed from Open to Assigned
- Assignee set to authorNari (Narihiro Nakamura)
- Target version set to 2.2.0
Please note: a number of libraries are using this class: https://github.com/search?l=ruby&q=LogDeviceMutex&ref=cmdform&type=Code
Updated by hsbt (Hiroshi SHIBATA) over 10 years ago
- Assignee changed from authorNari (Narihiro Nakamura) to nahi (Hiroshi Nakamura)
Updated by hsbt (Hiroshi SHIBATA) about 10 years ago
- Status changed from Assigned to Feedback
Your patch broke logger and syslog/logger tests.
Updated by naruse (Yui NARUSE) almost 7 years ago
- Target version deleted (
2.2.0)
Updated by hsbt (Hiroshi SHIBATA) over 5 years ago
- Assignee changed from nahi (Hiroshi Nakamura) to sonots (Naotoshi Seo)
Updated by sonots (Naotoshi Seo) about 5 years ago
This is already fixed via https://github.com/ruby/ruby/pull/541
Updated by sonots (Naotoshi Seo) about 5 years ago
- Status changed from Feedback to Closed
Actions
Like0
Like0Like0Like0Like0Like0Like0Like0