Feature #9532: Expose logger monitor

• Status: Closed
• Assignee: sonots (Naotoshi Seo)
• Target version: -

[arthurnn (Arthur Neves)]

I was wondering if we could do this type of change on the logger class:

https://github.com/arthurnn/ruby/commit/376b9f944948662ac816ad179ae90bc50a2a6c8f

I am proposing this, because if we have access to the mutex, on the logger instance, we would be able to synchronize methods such as, https://github.com/rails/rails/blob/95f5f8167ff86550d7fa9f5f7419cc9b38ef9704/activesupport/lib/active_support/logger_silence.rb#L12 . And make it thread-safe.

[zzak (zzak _)]

• Category set to lib
• Status changed from Open to Assigned
• Assignee set to authorNari (Narihiro Nakamura)
• Target version set to 2.2.0

Please note: a number of libraries are using this class: https://github.com/search?l=ruby&q=LogDeviceMutex&ref=cmdform&type=Code

[hsbt (Hiroshi SHIBATA)]

• Assignee changed from authorNari (Narihiro Nakamura) to nahi (Hiroshi Nakamura)

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Feedback

Your patch broke logger and syslog/logger tests.

[naruse (Yui NARUSE)]

• Target version deleted (2.2.0)

[hsbt (Hiroshi SHIBATA)]

• Assignee changed from nahi (Hiroshi Nakamura) to sonots (Naotoshi Seo)

[sonots (Naotoshi Seo)]

This is already fixed via https://github.com/ruby/ruby/pull/541

[sonots (Naotoshi Seo)]

• Status changed from Feedback to Closed