Bug #9608: [PATCH] avoid large alloca on Complex/Rational calls

• Status: Closed
• Assignee: tadf (tadayoshi funaba)
• Target version: -
• ruby -v: ruby 2.2.0dev (2014-03-07 trunk 45281) [x86_64-linux]
• Backport: 1.9.3: UNKNOWN, 2.0.0: DONE, 2.1: DONE

[normalperson (Eric Wong)]

• complex.c (parse_comp): replace ALLOCA_N with ALLOCV_N/ALLOCV_END
• rational.c (read_digits): ditto

This fixes segfaults on:

Rational("1" * 16 * 1024 * 1024)
Complex("1" * 16 * 1024 * 1024)

On my system where my stack size is only 8M.

tadf: Should we raise an exception on large string instead?
Large strings are slow to parse and could still be a DoS.

[normalperson (Eric Wong)]

• File 0001-avoid-large-alloca-on-Complex-Rational-calls.patch 0001-avoid-large-alloca-on-Complex-Rational-calls.patch added

[normalperson (Eric Wong)]

tadf: ping?

[tadf (tadayoshi funaba)]

i'd like to try it; please commit it.

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r45793.

---

avoid large alloca on Complex/Rational calls

• complex.c (parse_comp): replace ALLOCA_N with ALLOCV_N/ALLOCV_END
  [Bug #9608]
• rational.c (read_digits): ditto

[usa (Usaku NAKAMURA)]

• Backport changed from 1.9.3: UNKNOWN, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: UNKNOWN, 2.0.0: DONE, 2.1: REQUIRED

backported into ruby_2_0_0 at r46578.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: UNKNOWN, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: UNKNOWN, 2.0.0: DONE, 2.1: DONE

Backported into ruby_2_1 at r46612.