SMTP does not properly dot-stuff an unterminated last line
str = "Date: Wed, 12 Mar 2014 16:02:26 -0400\r\nFrom: email@example.com\r\nTo: firstname.lastname@example.org\r\nMessage-ID: <5320bd52be4d3_6d653fd3d8c339e458df@Joshs-MacBook-Pro.local.mail>\r\nMime-Version: 1.0\r\nContent-Type: text/plain;\r\n charset=UTF-8\r\nContent-Transfer-Encoding: 7bit\r\n\r\nlook, a period with no endline\r\n." smtp = Net::SMTP.new(...) smtp.start(...) do |smtp_obj| response = smtp_obj.sendmail(message, "email@example.com","firstname.lastname@example.org") end
The SMTP server is going to throw a 400 or 500 error (depending on it's configuration) because the last period is send un-stuffed in the DATA block:
look, a period with no endline . .
When it should be:
look, a period with no end line .. .
(ie, not dot-stuffed) and the second period the SMTP server doesn't know what to do with. Adding an additional new-line fixes the problem, but I the in-line documentation for SMTP send_message does not say anything about a new-line being requires for message sending to work.
Sorry, I can't test against the latest Ruby right now, but this is confirmed against 1.9.3 r448. If someone can confirm against newer that would be great.
I did do a search for "SMTP" and did not see this reported anywhere in the Issues database.
I had originally filed a pull request against Mail: https://github.com/mikel/mail/pull/683
Updated by yyyc514 (Josh Goebel) over 8 years ago
If I'm understanding this properly I think this monkey-patch is all it takes to fix it:
module Net class InternetMessageIO def using_each_crlf_line @wbuf = '' yield if not @wbuf.empty? # unterminated last line write0 dot_stuff(@wbuf.chomp) + "\r\n" elsif @written_bytes == 0 # empty src write0 "\r\n" end write0 ".\r\n" @wbuf = nil end def dot_stuff(s) s.sub(/\A\./, '..') end end end
You simply have to dot-stuff the remaining buffer if necessary...
Updated by nobu (Nobuyoshi Nakada) about 8 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100