Project

General

Profile

Backport #9630

Backport readline-6.3 support.

Added by hsbt (Hiroshi SHIBATA) over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
[ruby-dev:48035]

Description

Please backport to support readline-6.3 or later. Related revision are r45225, r45240 and 45243.


Related issues

Related to Ruby trunk - Bug #9578: ‘Function’ undeclared in readline.cClosed02/28/2014Actions
Related to Ruby trunk - Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用)Closed04/04/2014Actions

Associated revisions

Revision ab58587f
Added by nagachika (Tomoyuki Chikanaga) about 5 years ago

merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

    * ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
      of Function to support readline-6.3.  (rl_hook_func_t is available
      since readline-4.2.)
      Reported by Dmitry Medvinsky.  [ruby-core:61141] [Bug #9578]

    * ext/readline/extconf.rb (rl_hook_func_t): define as Function for
      very old readline versions.  [ruby-core:61209] [Bug #9578]

    * ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
      [ruby-core:61756] [Bug #9578]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@45772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 45772
Added by nagachika (Tomoyuki Chikanaga) about 5 years ago

merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
  of Function to support readline-6.3.  (rl_hook_func_t is available
  since readline-4.2.)
  Reported by Dmitry Medvinsky.  [ruby-core:61141] [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
  very old readline versions.  [ruby-core:61209] [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
  [ruby-core:61756] [Bug #9578]

Revision f2013ff8
Added by nagachika (Tomoyuki Chikanaga) about 5 years ago

merge revision(s) r45518: [Backport #9578] [Backport #9630] [Backport #9702]

    * ext/readline/extconf.rb (rl_hook_func_t): check pointer type.
      [ruby-dev:48089] [Bug #9702]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@45773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 45773
Added by nagachika (Tomoyuki Chikanaga) about 5 years ago

merge revision(s) r45518: [Backport #9578] [Backport #9630] [Backport #9702]

* ext/readline/extconf.rb (rl_hook_func_t): check pointer type.
  [ruby-dev:48089] [Bug #9702]

History

Updated by nobu (Nobuyoshi Nakada) over 5 years ago

  • Related to Bug #9578: ‘Function’ undeclared in readline.c added

Updated by ngoto (Naohisa Goto) about 5 years ago

  • Related to Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用) added

Updated by hsbt (Hiroshi SHIBATA) about 5 years ago

r45488 and r45518

Updated by nagachika (Tomoyuki Chikanaga) about 5 years ago

  • Status changed from Open to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)

Updated by nagachika (Tomoyuki Chikanaga) about 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r45772.


merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
  of Function to support readline-6.3.  (rl_hook_func_t is available
  since readline-4.2.)
  Reported by Dmitry Medvinsky.  [ruby-core:61141] [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
  very old readline versions.  [ruby-core:61209] [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
  [ruby-core:61756] [Bug #9578]

Also available in: Atom PDF