Backport #9630

Backport readline-6.3 support.

Added by Hiroshi SHIBATA about 1 year ago. Updated 12 months ago.

[ruby-dev:48035]
Status:Closed
Priority:Normal
Assignee:Tomoyuki Chikanaga

Description

Please backport to support readline-6.3 or later. Related revision are r45225, r45240 and 45243.


Related issues

Related to Ruby trunk - Bug #9578: ‘Function’ undeclared in readline.c Closed 02/28/2014
Related to Ruby trunk - Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用) Closed 04/04/2014

Associated revisions

Revision 45772
Added by Tomoyuki Chikanaga 12 months ago

merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
  of Function to support readline-6.3.  (rl_hook_func_t is available
  since readline-4.2.)
  Reported by Dmitry Medvinsky.   [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
  very old readline versions.   [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
   [Bug #9578]

Revision 45773
Added by Tomoyuki Chikanaga 12 months ago

merge revision(s) r45518: [Backport #9578] [Backport #9630] [Backport #9702]

* ext/readline/extconf.rb (rl_hook_func_t): check pointer type.
   [Bug #9702]

History

#1 Updated by Nobuyoshi Nakada about 1 year ago

  • Related to Bug #9578: ‘Function’ undeclared in readline.c added

#2 Updated by Naohisa Goto about 1 year ago

  • Related to Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用) added

#3 Updated by Hiroshi SHIBATA 12 months ago

r45488 and r45518

#4 Updated by Tomoyuki Chikanaga 12 months ago

  • Status changed from Open to Assigned
  • Assignee set to Tomoyuki Chikanaga

#5 Updated by Tomoyuki Chikanaga 12 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r45772.


merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
  of Function to support readline-6.3.  (rl_hook_func_t is available
  since readline-4.2.)
  Reported by Dmitry Medvinsky.   [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
  very old readline versions.   [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
   [Bug #9578]

Also available in: Atom PDF