Project

General

Profile

Backport #9630

Backport readline-6.3 support.

Added by hsbt (Hiroshi SHIBATA) over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
nagachika (Tomoyuki Chikanaga)
[ruby-dev:48035]

Description

Please backport to support readline-6.3 or later. Related revision are r45225, r45240 and 45243.

Related issues

Related to Ruby trunk - Bug #9578: ‘Function’ undeclared in readline.cClosed2014-02-28
Related to Ruby trunk - Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用)Closed2014-04-04

Associated revisions

Revision 45772
Added by nagachika (Tomoyuki Chikanaga) about 3 years ago

merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
of Function to support readline-6.3. (rl_hook_func_t is available
since readline-4.2.)
Reported by Dmitry Medvinsky. [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
very old readline versions. [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
[Bug #9578]

Revision 45773
Added by nagachika (Tomoyuki Chikanaga) about 3 years ago

merge revision(s) r45518: [Backport #9578] [Backport #9630] [Backport #9702]

* ext/readline/extconf.rb (rl_hook_func_t): check pointer type.
[Bug #9702]

History

#1 [ruby-dev:48052] Updated by nobu (Nobuyoshi Nakada) over 3 years ago

  • Related to Bug #9578: ‘Function’ undeclared in readline.c added

#2 [ruby-dev:48093] Updated by ngoto (Naohisa Goto) over 3 years ago

  • Related to Bug #9702: r45488以降、SolarisStudioで ext/readline がコンパイルエラー(readline 6.2使用) added

#3 [ruby-dev:48139] Updated by hsbt (Hiroshi SHIBATA) about 3 years ago

r45488 and r45518

#4 [ruby-dev:48159] Updated by nagachika (Tomoyuki Chikanaga) about 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)

#5 [ruby-dev:48160] Updated by nagachika (Tomoyuki Chikanaga) about 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r45772.

merge revision(s) r45225,r45240,r45488: [Backport #9578] [Backport #9630]

* ext/readline/readline.c (Init_readline): Use rl_hook_func_t instead
  of Function to support readline-6.3.  (rl_hook_func_t is available
  since readline-4.2.)
  Reported by Dmitry Medvinsky.   [Bug #9578]

* ext/readline/extconf.rb (rl_hook_func_t): define as Function for
  very old readline versions.   [Bug #9578]

* ext/readline/extconf.rb: fix typo, `$defs` not `$DEFS`.
   [Bug #9578]

Also available in: Atom PDF