Bug #10487: [PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: 2.2.0dev
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN

[gogotanaka (Kazuki Tanaka)]

Hi, there.

I was wondering which is prefer reporting this issue as bugs or feature.
Finally I decided to report as bugs because I thought such a issue being totally unexpected can be called bugs.

Aside from that, let me show the before my patch and after my patch.

Before

CMath.log(1i,1,1,1,1,1,1,1,1)
# => (NaN+Infinity*i)

After

CMath.log(1i,1,1,1,1,1,1,1,1)
# => ArgumentError: wrong number of arguments (9 for 1..2)

def log(z, b=E) may look little bit strange, but I assert for all num log(num) equal log(num, E)

and checking second argument passing or not takes pain.

Thanks. gogo.

[gogotanaka (Kazuki Tanaka)]

Only my concern is constant E can be overrided.

[gogotanaka (Kazuki Tanaka)]

Associated revision 10255

[gogotanaka (Kazuki Tanaka)]

ping

[gogotanaka (Kazuki Tanaka)]

ping

[marcandre (Marc-Andre Lafortune)]

Looks good. I would use ::Math::E instead of E for explicitness (I doubt anyone would defined CMath::E.
Also, bug fixes don't need a NEWS entry.

[gogotanaka (Kazuki Tanaka)]

@Marc-Andre Lafortune

sounds good, do I need to modify patch as you said?
If so, please feel free.

[ayumin (Ayumu AIZAWA)]

Hi Tanaka-san
Please post new patch which was applied Marc's review.
I would help you for assign the right person of ruby-core for this issue.
Regards.

[gogotanaka (Kazuki Tanaka)]

• File modify_cmath_rb_v2.patch modify_cmath_rb_v2.patch added

@Ayumu AIZAWA san

Thank you so much! Here you are.

[gogotanaka (Kazuki Tanaka)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r49729.

---

• lib/cmath.rb (log): raise ArgumentError when more than 2 arguments
  are passed. [ruby-core:66143] [Bug #10487]