Project

General

Profile

Actions
Copy link

Bug #10487

closed

[PATCH 3/3] More than 3 arguments Passing to CMath.log doesn't make sense.

Added by gogotanaka (Kazuki Tanaka) about 10 years ago. Updated almost 10 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
2.2.0dev
Backport:
2.0.0: UNKNOWN, 2.1: UNKNOWN
[ruby-core:66143]

Description

Hi, there.

I was wondering which is prefer reporting this issue as bugs or feature.
Finally I decided to report as bugs because I thought such a issue being totally unexpected can be called bugs.

Aside from that, let me show the before my patch and after my patch.

Before

CMath.log(1i,1,1,1,1,1,1,1,1)
# => (NaN+Infinity*i)

After

CMath.log(1i,1,1,1,1,1,1,1,1)
# => ArgumentError: wrong number of arguments (9 for 1..2)

def log(z, b=E) may look little bit strange, but I assert for all num log(num) equal log(num, E)

and checking second argument passing or not takes pain.

Thanks. gogo.

Files

Download all files
modify_cmath.rb.patch (1.15 KB) modify_cmath.rb.patch gogotanaka (Kazuki Tanaka), 11/08/2014 07:50 PM
adjust_test_complex.rb.patch (955 Bytes) adjust_test_complex.rb.patch gogotanaka (Kazuki Tanaka), 11/08/2014 07:50 PM
update_NEWS.patch (629 Bytes) update_NEWS.patch gogotanaka (Kazuki Tanaka), 11/08/2014 07:50 PM
modify_cmath_rb_v2.patch (1.16 KB) modify_cmath_rb_v2.patch gogotanaka (Kazuki Tanaka), 01/27/2015 02:29 AM
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0