Project

General

Profile

Actions

Bug #10716

closed

Erroneous semicolon after AC_CASE

Added by vo.x (Vit Ondruch) over 9 years ago. Updated about 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux-gnu]
[ruby-core:67429]

Description

This is issue when building with autoconf 2.63 available in RHEL6/CentOS6

BTW I am wondering why Ruby actually enforces autoconf 2.67 and makes plenty of RHEL 6/CentOS 6 users [1] unnecessary issues, when it builds with 2.63 just fine. If there was some justification at least [2].

[1] https://www.google.cz/search?q=ruby+Autoconf+version+2.67+or+higher+is+required
[2] https://github.com/ruby/ruby/commit/ecb9b98774b01b2eff22fe4a9832ce469f3552e8


Files

0001-Remove-superfluous-semicolon.patch (949 Bytes) 0001-Remove-superfluous-semicolon.patch vo.x (Vit Ondruch), 01/08/2015 01:26 PM

Updated by vo.x (Vit Ondruch) over 9 years ago

Forgot to mention the actual error:

$ autoconf
$ ./configure 
./configure: line 63225: syntax error near unexpected token `;'
./configure: line 63225: `; }; then'

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

Vit Ondruch wrote:

BTW I am wondering why Ruby actually enforces autoconf 2.67 and makes plenty of RHEL 6/CentOS 6 users [1] unnecessary issues, when it builds with 2.63 just fine. If there was some justification at least [2].

Because we wanted to skip autoconf 2.64 and 2.66 but AC_PREREQ() can't skip them but allow 2.63.

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r49192.


configure.in: Remove superfluous semicolon

  • configure.in (RUBY_SETJMP_TYPE): Remove superfluous semicolon
    which causes a syntax error with autoconf 2.63.
    [ruby-core:67429] [Bug #10716]

Updated by vo.x (Vit Ondruch) over 9 years ago

Nobuyoshi Nakada wrote:

Vit Ondruch wrote:

BTW I am wondering why Ruby actually enforces autoconf 2.67 and makes plenty of RHEL 6/CentOS 6 users [1] unnecessary issues, when it builds with 2.63 just fine. If there was some justification at least [2].

Because we wanted to skip autoconf 2.64 and 2.66 but AC_PREREQ() can't skip them but allow 2.63.

Ok, that makes sense. So I'll happily change the AC_PREREQ back to 2.63 for RHEL 6/CentOS 6 packages. Thanks for applying the patch.

Actions #5

Updated by usa (Usaku NAKAMURA) over 9 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: REQUIRED

Updated by naruse (Yui NARUSE) over 9 years ago

  • Backport changed from 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: DONE

ruby_2_2 r49328 merged revision(s) 49192.

Actions #7

Updated by nagachika (Tomoyuki Chikanaga) about 9 years ago

  • Backport changed from 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: DONE to 2.0.0: DONTNEED, 2.1: DONE, 2.2: DONE

Backported into ruby_2_1 branch at r50130.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0