Project

General

Profile

Feature #11084

Use rb-readline instead of ext/readline

Added by hsbt (Hiroshi SHIBATA) over 4 years ago. Updated 6 months ago.

Status:
Rejected
Priority:
Normal
Target version:
-
[ruby-core:<unknown>]

Description

Users who want to build ruby needs to prepare readline library.
Example for https://github.com/sstephenson/ruby-build/wiki#suggested-build-environment

Preparation of building environment is hard for many users.

I propose to use rb-readline that it's pure ruby implementation of readline instead of ext/readline.


Files

rb-readline.patch (99.2 KB) rb-readline.patch hsbt (Hiroshi SHIBATA), 04/21/2015 01:30 PM

History

#1

Updated by hsbt (Hiroshi SHIBATA) over 4 years ago

I missed to attach patch.

#2

Updated by usa (Usaku NAKAMURA) over 4 years ago

I'm neutral about this issue, but I wonder why you don't simply unbundle ext/readline instead of replacing it by rb-readline.

#3

Updated by Hanmac (Hans Mackowiak) over 4 years ago

i don't know about, the binding/implementation using the C lib might be faster and have more features
so using a pure-ruby implementation might not a 100% good idea

#4

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Assignee set to hsbt (Hiroshi SHIBATA)
  • Status changed from Open to Assigned

Updated by Eregon (Benoit Daloze) over 1 year ago

https://github.com/ConnorAtherton/rb-readline/blob/master/lib/rbreadline.rb is almost 9000 lines of Ruby code.
How fast does it load?
That seems important for command-line applications

Updated by hsbt (Hiroshi SHIBATA) 6 months ago

  • Status changed from Assigned to Rejected

The last update of rb-readline is 2 years ago. I think we shouldn't replace it.

And aycabta (aycabta .) try to create the readline alternative. If we replace readline to pure ruby implementation, we should use it.

Also available in: Atom PDF