Bug #11380: Parser regression in 2.3?

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.3.0dev (2015-07-21 trunk 51319) [x86_64-darwin14]
• Backport: 2.0.0: UNKNOWN, 2.1: DONE, 2.2: DONE

[matsuda (Akira Matsuda)]

This code works with 2.2 but causes SyntaxError with 2.3.

def foo(pr, options, &blk)
  p pr.call
end

foo -> { :hello }, a: 1 do end

#=> t.rb:5: syntax error, unexpected keyword_do, expecting end-of-input

[yui-knk (Kaneko Yuichiro)]

I found out that this regression is caused by 50402 (https://github.com/ruby/ruby/commit/fd0e9d2580bf757071683581d34354064c6ceb6a)

# prase.rb
def foo(pr, options, &blk)
  p pr.call
end

foo -> { :hello }, a: 1 do end

$  /usr/local/bin/ruby  -v
ruby 2.3.0dev (2015-04-29 trunk 50401) [x86_64-darwin13]

$  /usr/local/bin/ruby  parse.rb
:hello

$  /usr/local/bin/ruby  -v
ruby 2.3.0dev (2015-04-29 trunk 50402) [x86_64-darwin13]

$  /usr/local/bin/ruby  parse.rb
../parse.rb:5: syntax error, unexpected keyword_do, expecting end-of-input
foo -> { :hello }, a: 1 do end

[nobu (Nobuyoshi Nakada)]

• Related to Bug #11107: Syntax error is raised by "p ->() do a(1) do end end", but not by "p ->() do a 1 do end end" added

[nobu (Nobuyoshi Nakada)]

• Has duplicate Bug #11389: Regression in method parameter parsing added

[felixbuenemann (Felix Bünemann)]

• Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: REQUIRED

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r51350.

---

parse.y: pop cmdarg

• parse.y (lambda_body): pop cmdarg stack for lookahead
  token. [ruby-core:70067] [Bug #11380]

[felixbuenemann (Felix Bünemann)]

This still needs to be backported.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: DONE

Backported into ruby_2_2 branch at r51519.

[felixbuenemann (Felix Bünemann)]

Thank you!

Please don't forget to also backport to ruby_2_1, because #11107 which caused this regression was backported to ruby_2_1 aswell.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: DONE to 2.0.0: UNKNOWN, 2.1: DONE, 2.2: DONE

ruby_2_1 r51605 merged revision(s) 51350.