Project

General

Profile

Bug #11945

[PATCH] stringio: binmode sets encoding to ASCII-8BIT

Added by normalperson (Eric Wong) over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:72699]

Description

stringio: binmode sets encoding to ASCII-8BIT

This should match the behavior of IO#binmode as far
as treating content as ASCII-8BIT (binary).


Files

Updated by nobu (Nobuyoshi Nakada) over 4 years ago

  • Status changed from Open to Assigned
  • Assignee set to normalperson (Eric Wong)

Good point.
Just adjust the indent as the rest, please.

#2

Updated by Anonymous over 4 years ago

  • Status changed from Assigned to Closed

Applied in changeset r53435.


stringio: binmode sets encoding to ASCII-8BIT

This should match the behavior of IO#binmode as far
as treating content as ASCII-8BIT (binary).

  • ext/stringio/stringio.c (strio_binmode): implement to set encoding
  • test/stringio/test_stringio.rb (test_binmode): new test [ruby-core:72699] [Bug #11945]

Updated by normalperson (Eric Wong) over 4 years ago

nobu@ruby-lang.org wrote:

Good point.
Just adjust the indent as the rest, please.

Thanks for the extra eyes, fixed up indent and committed r53435

Unsubscribe: ruby-core-request@ruby-lang.org?subject=unsubscribe
http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core

Updated by usa (Usaku NAKAMURA) over 4 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE, 2.2: REQUIRED, 2.3: REQUIRED

ruby_2_1 r53927 merged revision(s) 53435.

Updated by nagachika (Tomoyuki Chikanaga) over 4 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE, 2.2: REQUIRED, 2.3: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE, 2.3: REQUIRED

Backported into ruby_2_2 branch at r54042.

Updated by naruse (Yui NARUSE) over 4 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE, 2.3: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE, 2.3: DONE

ruby_2_3 r54353 merged revision(s) 53435.

Also available in: Atom PDF