Project

General

Profile

Bug #12069

[PATCH] document OpenSSL::SSL::SSLContext#setup as MT-unsafe

Added by normalperson (Eric Wong) over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:73803]

Description

document OpenSSL::SSL::SSLContext#setup as MT-unsafe

On a cursory inspection, using rb_block_call for extra_chain_cert
is thread-unsafe. There may be other instances of thread-unsafe
behavior in this method, but one is enough.

  • ext/openssl/ossl_ssl.c (ossl_sslctx_setup): document as MT-unsafe

Files

#1

Updated by Anonymous over 4 years ago

  • Status changed from Open to Closed

Applied in changeset r54097.


document OpenSSL::SSL::SSLContext#setup as MT-unsafe

On a cursory inspection, using rb_block_call for extra_chain_cert
is thread-unsafe. There may be other instances of thread-unsafe
behavior in this method, but one is enough.

  • ext/openssl/ossl_ssl.c (ossl_sslctx_setup): document as MT-unsafe [ruby-core:73803] [Bug #12069]

Updated by normalperson (Eric Wong) over 4 years ago

Committed with a minor wording change as r54097
s/SSLSockets/SSLSocket objects/ for searchability

Updated by usa (Usaku NAKAMURA) over 4 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED

Updated by usa (Usaku NAKAMURA) over 4 years ago

  • Backport changed from 2.1: REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: DONE, 2.2: REQUIRED, 2.3: REQUIRED

ruby_2_1 r54282 merged revision(s) 54097.

Updated by nagachika (Tomoyuki Chikanaga) over 4 years ago

  • Backport changed from 2.1: DONE, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: DONE, 2.2: DONE, 2.3: REQUIRED

Backported into ruby_2_2 branch at r54332.

Updated by naruse (Yui NARUSE) over 4 years ago

  • Backport changed from 2.1: DONE, 2.2: DONE, 2.3: REQUIRED to 2.1: DONE, 2.2: DONE, 2.3: DONE

ruby_2_3 r54379 merged revision(s) 54097.

Also available in: Atom PDF