Project

General

Profile

Actions
Copy link

Bug #13107

closed

def_delegators causes random errors in MRI 2.4.0

Added by twalpole@gmail.com (Thomas Walpole) over 7 years ago. Updated about 7 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: DONE
[ruby-core:78981]

Description

In the Capybara project we use the rack_test gem which uses def_delegators to forward flast_reponse to @rack_mock_session - https://github.com/brynary/rack-test/blob/master/lib/rack/test.rb#L29

When running the Capybara test test suite calling last_reponse on a rack_test Session object will sporadically result in a TypeError from forwardable.rb

TypeError:
       wrong argument type Integer (expected Proc)

Patching around the delegator with

class Rack::Test::Session
  def last_response
    @rack_mock_session.last_response
  end
end

stops the error from occurring, so it appears that something def_delegators is doing is causing problems. Unfortunately I have not yet been able to establish exactly what causes the issues to produce a simple test case.

Files

Download all files
0001-forwardable.rb-use-public_send-to-call-method.patch (789 Bytes) 0001-forwardable.rb-use-public_send-to-call-method.patch eugeneius (Eugene Kenny), 01/08/2017 01:48 AM
0001-forwardable-impl.rb-include-trace-instruction.patch (773 Bytes) 0001-forwardable-impl.rb-include-trace-instruction.patch eugeneius (Eugene Kenny), 01/08/2017 02:20 AM
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0