Project

General

Profile

Bug #14607

Fix use of the rb_profile_frames start parameter

Added by dylants (Dylan Thacker-Smith) 9 months ago. Updated 8 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:86147]

Description

rb_profile_frames was always behaving as if the value given for the start parameter was 0.

The reason for this was that it would check if (start > 0) { then continue without updating the control frame pointer or anything other than decrementing start.

This bug applies to all branches under normal maintenance, from ruby 2.3 to trunk.

Associated revisions

Revision d676ad10
Added by tenderlove 8 months ago

Fix use of rb_profile_frames start parameter

rb_profile_frames was always behaving as if the value given for the
start parameter was 0.

The reason for this was that it would check if (start > 0) { then
continue without updating the control frame pointer or anything other
than decrementing start.

[Bug #14607]

Co-authored-by: Dylan Thacker-Smith Dylan.Smith@shopify.com

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 63265
Added by tenderlovemaking (Aaron Patterson) 8 months ago

Fix use of rb_profile_frames start parameter

rb_profile_frames was always behaving as if the value given for the
start parameter was 0.

The reason for this was that it would check if (start > 0) { then
continue without updating the control frame pointer or anything other
than decrementing start.

[Bug #14607]

Co-authored-by: Dylan Thacker-Smith Dylan.Smith@shopify.com

History

#1 Updated by tenderlovemaking (Aaron Patterson) 8 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63265.


Fix use of rb_profile_frames start parameter

rb_profile_frames was always behaving as if the value given for the
start parameter was 0.

The reason for this was that it would check if (start > 0) { then
continue without updating the control frame pointer or anything other
than decrementing start.

[Bug #14607]

Co-authored-by: Dylan Thacker-Smith Dylan.Smith@shopify.com

#2 [ruby-core:86704] Updated by tenderlovemaking (Aaron Patterson) 8 months ago

  • Status changed from Closed to Open

ko1 said I shouldn't have committed the patch, so I reverted. Sorry!

#3 [ruby-core:86705] Updated by ko1 (Koichi Sasada) 8 months ago

I need to remember why such special (additional) calculation is done, so I left this ticket.
I need to remember...

Also available in: Atom PDF