Bug #14607
Fix use of the rb_profile_frames start parameter
Description
rb_profile_frames was always behaving as if the value given for the start parameter was 0.
The reason for this was that it would check if (start > 0) {
then continue
without updating the control frame pointer or anything other than decrementing start
.
This bug applies to all branches under normal maintenance, from ruby 2.3 to trunk.
Updated by tenderlovemaking (Aaron Patterson) almost 3 years ago
- Status changed from Open to Closed
Applied in changeset trunk|r63265.
Fix use of rb_profile_frames
start parameter
rb_profile_frames was always behaving as if the value given for the
start parameter was 0.
The reason for this was that it would check if (start > 0) { then
continue without updating the control frame pointer or anything other
than decrementing start.
[ruby-core:86147] [Bug #14607]
Co-authored-by: Dylan Thacker-Smith Dylan.Smith@shopify.com
Updated by tenderlovemaking (Aaron Patterson) almost 3 years ago
- Status changed from Closed to Open
ko1 said I shouldn't have committed the patch, so I reverted. Sorry!
Updated by ko1 (Koichi Sasada) almost 3 years ago
I need to remember why such special (additional) calculation is done, so I left this ticket.
I need to remember...
Updated by dylants (Dylan Thacker-Smith) 7 months ago
- File deleted (
fix-use-of-the-rb_profile_frames-start-parameter.patch)
The original patch has a merge conflict. However, I have opened a pull request with the fix for this issue (https://github.com/ruby/ruby/pull/2713) that has been rebased to resolve the merge conflict.