Project

General

Profile

Actions

Bug #14655

closed

new TestTimeTZ test failures

Added by terceiro (Antonio Terceiro) about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.6.0dev (2018-03-31 master 63048) [x86_64-linux]
[ruby-core:86417]

Description

$ make test-all TESTS=test/ruby/test_time_tz.rb
Run options: "--ruby=./miniruby -I./lib -I. -I.ext/common  ./tool/runruby.rb --extout=.ext  -- --disable-gems" --excludes-dir=./test/excludes --name=!/memory_leak/

# Running tests:

[ 95/110] TestTimeTZ#test_gen_Pacific_Kiritimati_71 = 0.00 s 
  1) Failure:
TestTimeTZ#test_gen_Pacific_Kiritimati_71 [/home/terceiro/src/ruby/test/ruby/test_time_tz.rb:265]:
TZ=Pacific/Kiritimati Time.utc(1995, 1, 1, 9, 59, 59).localtime.
<"1994-12-31 23:59:59 -1000"> expected but was
<"1995-01-01 23:59:59 +1400">.

[ 97/110] TestTimeTZ#test_gen_Pacific_Kiritimati_89 = 0.00 s
  2) Failure:
TestTimeTZ#test_gen_Pacific_Kiritimati_89 [/home/terceiro/src/ruby/test/ruby/test_time_tz.rb:283]:
TZ=Pacific/Kiritimati Time.local(1994, 12, 31, 23, 59, 59).
<"1994-12-31 23:59:59 -1000"> expected but was
<"1995-01-01 23:59:59 +1400">.

[ 99/110] TestTimeTZ#test_gen_lisbon_99 = 0.00 s            
  3) Failure:
TestTimeTZ#test_gen_lisbon_99 [/home/terceiro/src/ruby/test/ruby/test_time_tz.rb:408]:
Expected [[false, false, false, false, false], [false, false, false, false, false]] to include [true, true, true, true, true].

[108/110] TestTimeTZ#test_pacific_kiritimati = 0.00 s              
  4) Failure:
TestTimeTZ#test_pacific_kiritimati [/home/terceiro/src/ruby/test/ruby/test_time_tz.rb:181]:
TZ=Pacific/Kiritimati Time.local(1994, 12, 31, 23, 59, 59).
<"1994-12-31 23:59:59 -1000"> expected but was
<"1995-01-01 23:59:59 +1400">.

Finished tests in 0.028217s, 3898.4136 tests/s, 36007.1654 assertions/s.
110 tests, 1016 assertions, 4 failures, 0 errors, 0 skips

ruby -v: ruby 2.6.0dev (2018-03-31 master 63048) [x86_64-linux]
make: *** [uncommon.mk:731: yes-test-all] Error 4

Relevant parts of the latest tzdata update:

Enderbury and Kiritimati skipped New Year's Eve 1994, not
New Year's Day 1995. (Thanks to Kerry Shetline.)

Fix the 1912-01-01 transition for Portugual and its colonies.
This transition was at 00:00 according to the new UT offset, not
according to the old one. Also assume that Cape Verde switched on
the same date as the rest, not in 1907. This affects
Africa/Bissau, Africa/Sao_Tome, Asia/Macau, Atlantic/Azores,
Atlantic/Cape_Verde, Atlantic/Madeira, and Europe/Lisbon.
(Thanks to Michael Deckers.)

Actions #1

Updated by nobu (Nobuyoshi Nakada) about 3 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63054.


test_time_tz.rb: Kiritimati tzdata fix

  • test/ruby/test_time_tz.rb (TestTimeTZ#test_pacific_kiritimati): fix the expected data at the skip of New Year's Eve 1994. [Bug #14655]
Actions #2

Updated by naruse (Yui NARUSE) about 3 years ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED

Updated by usa (Usaku NAKAMURA) almost 3 years ago

  • Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: DONE, 2.5: REQUIRED

ruby_2_4 r63808 merged revision(s) 63054,63055,63056.

Updated by nagachika (Tomoyuki Chikanaga) almost 3 years ago

  • Backport changed from 2.3: REQUIRED, 2.4: DONE, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

ruby_2_5 r63817 merged revision(s) 63054,63055,63056.

Actions

Also available in: Atom PDF