Project

General

Profile

Feature #15594

[PATCH] net/imap: support SNI

Added by Keruspe (Marc-Antoine Perennou) 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:91466]

Description

This fixes connecting using TLS 1.3 to imap.gmail.com

See https://github.com/ruby/openssl/issues/238 and https://github.com/ruby/ruby/pull/2077


Files

0001-net-imap-support-SNI.patch (914 Bytes) 0001-net-imap-support-SNI.patch Keruspe (Marc-Antoine Perennou), 02/27/2019 04:32 PM

Related issues

Related to Ruby master - Bug #15769: Backport r67563: SNI is not enabled in Net::IMAPClosedActions
Related to Ruby master - Bug #16028: Backport r67563: SNI is not enabled in Net::IMAPClosedActions

Associated revisions

Revision e553d94f
Added by shugo (Shugo Maeda) 5 months ago

Support SNI

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou Marc-Antoine@Perennou.com

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 67488
Added by shugo (Shugo Maeda) 5 months ago

Support SNI

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou Marc-Antoine@Perennou.com

Revision 246723a3
Added by knu (Akinori MUSHA) 5 months ago

Support SNI (Reapplying r67488)

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou Marc-Antoine@Perennou.com

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 67563
Added by knu (Akinori MUSHA) 5 months ago

Support SNI (Reapplying r67488)

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou Marc-Antoine@Perennou.com

Revision edb7ec21
Added by naruse (Yui NARUSE) 5 months ago

merge revision(s) 67563:

    Support SNI (Reapplying r67488)

    This fixes connecting using TLS 1.3 to imap.gmail.com

    [Fix GH-2077] [Feature #15594]

    From: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67564 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 67564
Added by naruse (Yui NARUSE) 5 months ago

merge revision(s) 67563:

Support SNI (Reapplying r67488)

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

Revision 402bf6d5
Added by usa (Usaku NAKAMURA) about 2 months ago

merge revision(s) 67563: [Backport #15769]

    Support SNI (Reapplying r67488)

    This fixes connecting using TLS 1.3 to imap.gmail.com

    [Fix GH-2077] [Feature #15594]

    From: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 67717
Added by usa (Usaku NAKAMURA) about 2 months ago

merge revision(s) 67563: [Backport #15769]

Support SNI (Reapplying r67488)

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

History

Updated by znz (Kazuhiro NISHIYAMA) 7 months ago

  • Assignee set to shugo (Shugo Maeda)
  • Status changed from Open to Assigned
#2

Updated by Keruspe (Marc-Antoine Perennou) 7 months ago

Updated by knu (Akinori MUSHA) 5 months ago

I think this is necessary for the library to be able to connect to the Gmail server which now requires SNI.

Updated by knu (Akinori MUSHA) 5 months ago

Maybe POP3 & SMTP need this too.

Updated by knu (Akinori MUSHA) 5 months ago

Here's a possible workaround:

require 'net/protocol'

class Net::Protocol
  module ForceSNI
    def ssl_socket_connect(*)
      @sock.hostname = @host if @sock.respond_to? :hostname=
      super
    end
  end

  prepend ForceSNI
end
#6

Updated by shugo (Shugo Maeda) 5 months ago

  • Status changed from Assigned to Closed

Applied in changeset trunk|r67488.


Support SNI

This fixes connecting using TLS 1.3 to imap.gmail.com

[Fix GH-2077] [Feature #15594]

From: Marc-Antoine Perennou Marc-Antoine@Perennou.com

#7

Updated by naruse (Yui NARUSE) 5 months ago

  • Related to Bug #15769: Backport r67563: SNI is not enabled in Net::IMAP added
#8

Updated by hone (Terence Lee) about 2 months ago

  • Related to Bug #16028: Backport r67563: SNI is not enabled in Net::IMAP added

Also available in: Atom PDF