Project

General

Profile

Actions

Bug #16922

closed

single quote should be escaped in xml

Added by lisbethw1130 (Lisbeth Wu) about 4 years ago. Updated about 2 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]
[ruby-core:98576]

Description

This is Lisbeth from Taiwan. I'm trying to convert a string to xml by using 'string'.encode(xml: :attr) but single quote doesn't escape as expected
Here's the spec shows which character needs to be escaped: https://www.w3.org/TR/xml/#dt-escape

and I found a more clean table in sitemap spec: https://www.sitemaps.org/protocol.html#escaping

Ampersand 	& 	&
Single Quote 	' 	'
Double Quote 	" 	"
Greater Than 	> 	>
Less Than 	< 	&lt;

expected output:

puts ':$+,;:=?@&'"><'.encode(xml: :attr)

":$+,;:=?@&amp; **&apos;** &quot;&gt;&lt;"

real output:

":$+,;:=?@&amp; **'** &quot;&gt;&lt;"

Thanks for helping

Actions #1

Updated by shyouhei (Shyouhei Urabe) almost 4 years ago

  • Description updated (diff)

Updated by jeremyevans0 (Jeremy Evans) almost 4 years ago

  • Assignee set to akr (Akira Tanaka)

I've added a pull request to escape ' as &apos;: https://github.com/ruby/ruby/pull/3177

@akr (Akira Tanaka), can you let me know if this is correct?

Updated by lisbethw1130 (Lisbeth Wu) almost 4 years ago

any update about this issue?

Updated by jeremyevans0 (Jeremy Evans) almost 4 years ago

Well, I haven't heard from @akr (Akira Tanaka). But if he doesn't respond in the next few days, I'll merge my pull request.

Actions #5

Updated by jeremyevans (Jeremy Evans) almost 4 years ago

  • Status changed from Open to Closed

Applied in changeset git|ddd9704ae9bf884d867b6f57a16c095a79393fff.


Encode ' as ' when using encode(xml: :attr)

Fixes [Bug #16922]

Updated by headius (Charles Nutter) about 2 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN to 2.5: UNKNOWN, 2.6: REQUIRED, 2.7: REQUIRED, 3.0: REQUIRED

Requesting backport to 2.6. JRuby runs the CRuby test suite and wants to fix the same issue, but the existing tests in ruby_2_6 branch fail.

Updated by headius (Charles Nutter) about 2 years ago

See https://github.com/jruby/jruby/pull/7142 for JRuby update of our jcodings encoding backend, plus the test changes from https://github.com/ruby/ruby/pull/3177.

Updated by nagachika (Tomoyuki Chikanaga) about 2 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: REQUIRED, 2.7: REQUIRED, 3.0: REQUIRED to 2.6: REQUIRED, 2.7: REQUIRED, 3.0: DONTNEED

ruby_3_0 branch includes the changeset git|ddd9704ae9bf884d867b6f57a16c095a79393fff.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0