Bug #17215
closedBackport for arm64 optimizations that exist for power/x86
Description
Is it possible to backport this commit to ruby_2_7?
Enable arm64 optimizations that exist for power/x86
https://github.com/ruby/ruby/commit/511b55bcefc81c036294dc9a544d14bd342acd3b
The commit comes from https://github.com/ruby/ruby/pull/3393 .
Thanks.
Updated by ali (Ali Saidi) over 3 years ago
jaruga (Jun Aruga) wrote:
Is it possible to backport this commit to ruby_2_7?
Enable arm64 optimizations that exist for power/x86
https://github.com/ruby/ruby/commit/511b55bcefc81c036294dc9a544d14bd342acd3b
The commit comes from https://github.com/ruby/ruby/pull/3393 .Thanks.
I'm happy to submit a backport. I've tried it and it's pretty trivial.
Updated by jaruga (Jun Aruga) over 3 years ago
Hi Ali, thanks for your help!
Please note I think the commit is a new feature, and the ticket with "Tracker: Feature" does not have the backport field to make the backport easy. But if someone likes changing the Tracker type from Feature to Bug, I am happy to change it.
Updated by naruse (Yui NARUSE) over 3 years ago
As you know Ruby only backports bugfixes. If you think this is a feature, it won't be backported.
But note that in CRuby context "bug" is defined as fixes which may be backported.
If you believe a fix is a bug, you can request to backport it even if some other people think it's a feature.
The final decision is made by the branch maintainer, whether or not people consider it a bug.
Updated by jaruga (Jun Aruga) over 3 years ago
- Tracker changed from Feature to Bug
- Backport set to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: REQUIRED
Thanks for explaining the context of "bug" in CRuby.
In the context, I think the commit is to fix the relatively slower performance by the optimization, while there are already x86 and powerpc applying the optimization. So, I change the Tracker type to "bug", and pass the baton to the branch maintainer.
Updated by vo.x (Vit Ondruch) over 3 years ago
- Status changed from Open to Closed
I am going to use this patch on Fedora, if it helps:
Updated by jaruga (Jun Aruga) over 3 years ago
I am asking the backport to Ruby project's 2.7 branch.
If you use the patch on Fedora, why does it connect for you to close this ticket's status?
Updated by jeremyevans0 (Jeremy Evans) over 3 years ago
jaruga (Jun Aruga) wrote in #note-6:
I am asking the backport to Ruby project's 2.7 branch.
If you use the patch on Fedora, why does it connect for you to close this ticket's status?
Backport issues are closed after the appropriate backport marker has been set, similarly to how regular bug fixes are closed after the code has been fixed in master. It is still up to the branch maintainer whether they want to backport the fix.
You can check that this issue is on the "Backport 2.7" list: https://bugs.ruby-lang.org/projects/ruby-master/issues?query_id=172
Updated by jaruga (Jun Aruga) over 3 years ago
Thank you for the explanation. I remember the backporting rule now. I am sorry for disturbing you.
Updated by nagachika (Tomoyuki Chikanaga) about 3 years ago
- Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: REQUIRED to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: DONE
ruby_2_7 6ef46f71c743507a0e2ae0eef14dce0539b0ff52 merged revision(s) 511b55bcefc81c036294dc9a544d14bd342acd3b.