Project

General

Profile

Actions

Feature #18571

closed

Removed the bundled sources from release package after Ruby 3.2

Added by hsbt (Hiroshi SHIBATA) over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:107481]

Description

We shipped release package with the 3rd party source for mswin environment especially.

The current status is here:

  • libyaml: psych gem, ruby repo and package always bundled it.
  • libffi: only ruby package bundled it. fiddle gem and repo are not bundled.
  • zlib: gem, ruby repo and package don't bundled.

I propose we stop bundling the third-party source for security and maintenance reasons. Because we have vcpkg for mswin environment today. So, vcpkg provides the runtime for psych, fiddle and zlib.


Related issues 3 (0 open3 closed)

Related to Ruby master - Bug #18666: No rule to make target 'yaml/yaml.h', needed by 'api.o'Feedbackhsbt (Hiroshi SHIBATA)Actions
Related to Ruby master - Bug #18790: cannot load such file -- digest (LoadError)Closedhsbt (Hiroshi SHIBATA)Actions
Related to Ruby master - Bug #18034: Segmentation fault fiddle with `--enable-bundled-libffi` and macOSClosedkou (Kouhei Sutou)Actions

Updated by mame (Yusuke Endoh) over 1 year ago

@tenderlovemaking's comment for psych and libffi: https://github.com/ruby/psych/issues/535

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to hsbt (Hiroshi SHIBATA)

We decided on the following policy.

  • We will remove the bundled sources from ruby repo.
  • If users put the third-party source under the ruby packages, ruby build system use them.

Updated by matz (Yukihiro Matsumoto) over 1 year ago

Accepted, for the record.

Matz.

Actions #4

Updated by hsbt (Hiroshi SHIBATA) about 1 year ago

  • Related to Bug #18666: No rule to make target 'yaml/yaml.h', needed by 'api.o' added
Actions #5

Updated by nobu (Nobuyoshi Nakada) about 1 year ago

  • Status changed from Assigned to Closed

Applied in changeset git|282baa694320bbe385693902dfde0bdf93a532b8.


[DOC] Move the entry for [Feature #18571]

Actions #6

Updated by hsbt (Hiroshi SHIBATA) about 1 year ago

  • Status changed from Closed to Assigned

Updated by hsbt (Hiroshi SHIBATA) 9 months ago

The current distributed package still contained libyaml and libffi sources.

We will remove them and introduce the instructions to download them when building ruby like ./configure --enable-download-source.

Actions #9

Updated by hsbt (Hiroshi SHIBATA) 8 months ago

  • Related to Bug #18790: cannot load such file -- digest (LoadError) added
Actions #10

Updated by hsbt (Hiroshi SHIBATA) 8 months ago

  • Related to Bug #18034: Segmentation fault fiddle with `--enable-bundled-libffi` and macOS added

Updated by hsbt (Hiroshi SHIBATA) 8 months ago

I and nobu added --with-xxx-source-dir option for psych and fiddle instead of --enable-bundled-libyaml.

The users who want to use newer version of libyaml or libffi environment can use this option like gem install psych -- --with-libyaml-source-dir=$(pwd)/libyaml-0.2.5.

Updated by hsbt (Hiroshi SHIBATA) 7 months ago

  • Target version set to 3.2

We should add the additional options and instructions to document or NEWS.

Updated by hsbt (Hiroshi SHIBATA) 7 months ago

  • Status changed from Assigned to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0