Bug #22432
closedRange#include? returns true for the end of an empty range of single-character Strings
Description
A Range whose ends are both single ASCII characters reports that it includes its end even when the range is empty.
r = "z".."a"
r.to_a #=> []
r.include?("a") #=> true
r.member?("a") #=> true
r.cover?("a") #=> false
r === "a" #=> false
I expect include? and member? to return false here, as cover? does and as iterating the range implies. The same happens with digits, for example ("1".."0").include?("0").
Only the end is affected. Other values are correctly reported as not included:
Range#include? has a shortcut for ranges of single-character Strings, which compares the characters instead of iterating. It is in rb_str_include_range_p in string.c:
if (ISASCII(b) && ISASCII(e) && ISASCII(v)) {
if (b <= v && v < e) return Qtrue;
return RBOOL(!RTEST(exclusive) && v == e);
}
The last line returns true whenever the value equals the end, without checking that the begin is not after the end.
Updated by eightbitraptor (Matt V-H) about 1 month ago
Thanks for the report. Addressed in https://github.com/ruby/ruby/pull/19317
Updated by sferik (Erik Berlin) about 1 month ago
ยท Edited
@eightbitraptor (Matt V-H): Thanks. I previously submitted a nearly identical fix for this in https://github.com/ruby/ruby/pull/19313. CI is already green there.
Updated by nobu (Nobuyoshi Nakada) about 1 month ago
- Backport changed from 3.3: UNKNOWN, 3.4: UNKNOWN, 4.0: UNKNOWN to 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED
Updated by sferik (Erik Berlin) about 1 month ago
Backport PRs¶
3.3: https://github.com/ruby/ruby/pull/19395
3.4: https://github.com/ruby/ruby/pull/19396
4.0: https://github.com/ruby/ruby/pull/19397
Updated by nagachika (Tomoyuki Chikanaga) about 1 month ago
- Backport changed from 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED to 3.3: REQUIRED, 3.4: DONE, 4.0: REQUIRED
Thank you for creating PRs.
Merged into ruby_3_4at https://github.com/ruby/ruby/commit/26a4d835f7512f0615f6e0d7ed483c3438373b7e.
Updated by k0kubun (Takashi Kokubun) about 23 hours ago
- Backport changed from 3.3: REQUIRED, 3.4: DONE, 4.0: REQUIRED to 3.3: REQUIRED, 3.4: DONE, 4.0: DONE
ruby_4_0 4ba4954dd704bd08ebe3749fdfa3229344ddf5b1 merged revision(s) 1bf91309438d071359aa521328074cc6ec293299.
Updated by byroot (Jean Boussier) about 22 hours ago
- Status changed from Open to Closed