Project

General

Profile

Feature #3793

No test for OpenSSL::PKCS12

Added by nahi (Hiroshi Nakamura) almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:32088]

Description

=begin
As a task.
=end

Associated revisions

Revision 32690
Added by emboss about 6 years ago

  • test/openssl/test_pkcs12.rb: Add test and intermediate certificates. [ Ruby 1.9 - Feature #3793 ]

Revision 32690
Added by emboss about 6 years ago

  • test/openssl/test_pkcs12.rb: Add test and intermediate certificates. [ Ruby 1.9 - Feature #3793 ]

Revision 32690
Added by emboss about 6 years ago

  • test/openssl/test_pkcs12.rb: Add test and intermediate certificates. [ Ruby 1.9 - Feature #3793 ]

Revision 32690
Added by emboss about 6 years ago

  • test/openssl/test_pkcs12.rb: Add test and intermediate certificates. [ Ruby 1.9 - Feature #3793 ]

History

#1 Updated by nahi (Hiroshi Nakamura) almost 7 years ago

  • Priority changed from Normal to 3

=begin
Sorry takau, it's a test issue so I mark this Priority 'Low'.
=end

#2 Updated by shyouhei (Shyouhei Urabe) almost 7 years ago

  • Status changed from Open to Assigned

=begin

=end

#3 Updated by tenderlovemaking (Aaron Patterson) over 6 years ago

  • Assignee changed from nahi (Hiroshi Nakamura) to tenderlovemaking (Aaron Patterson)

=begin
I will add some tests.
=end

#4 [ruby-core:37423] Updated by nahi (Hiroshi Nakamura) about 6 years ago

  • Assignee changed from tenderlovemaking (Aaron Patterson) to nahi (Hiroshi Nakamura)
  • Target version changed from 1.9.2 to 1.9.3

#5 [ruby-core:37522] Updated by MartinBosslet (Martin Bosslet) about 6 years ago

Hiroshi, I could take this if you'd like?

I'm basically through with 1.9.3 issues assigned to me, please let
me know how I can help further for the upcoming release!

Regards,
Martin

#6 [ruby-core:37532] Updated by nahi (Hiroshi Nakamura) about 6 years ago

  • Assignee changed from nahi (Hiroshi Nakamura) to MartinBosslet (Martin Bosslet)

Martin, thank you for your concern. I'll change 'Assignee' of ext/openssl tickets to you. Please send those ticket back to me as you like.

For this ticket, Aaron added test_pkcs12.rb IIRC so you should be able to close it soon.

#7 [ruby-core:37533] Updated by MartinBosslet (Martin Bosslet) about 6 years ago

Hiroshi Nakamura wrote:

Martin, thank you for your concern. I'll change 'Assignee' of ext/openssl tickets to you. Please send those ticket back to me as you like.

Ok, thanks! Once we're done with the tickets and reach the code freeze phase I wanted to concentrate on adding tests and doc for OpenSSL. Please feel free to approach me with any other pre-release emergencies (testing etc.)!

For this ticket, Aaron added test_pkcs12.rb IIRC so you should be able to close it soon.

Yes, I just saw Aaron's tests there - I guess we can close this?

#8 Updated by naruse (Yui NARUSE) about 6 years ago

  • Target version changed from 1.9.3 to 2.0.0

#9 Updated by Anonymous about 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32690.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • test/openssl/test_pkcs12.rb: Add test and intermediate certificates. [ Ruby 1.9 - Feature #3793 ]

#10 [ruby-core:38539] Updated by MartinBosslet (Martin Bosslet) about 6 years ago

There was not really much to add to Aaron's tests. I included a CA and an intermediate CA certificate, and one additional test.

But I noticed three things:

1) What is OpenSSL::PKCS12.new good for? It seems like it's useless - the PKCS12 attributes are read-only...

2) ... but probably shouldn't be? Currently, there's no way for changing a PKCS#12 file's password, which could be quite useful.

3) When writing the test I realized that OpenSSL::X509::Certificate and OpenSSL::PKey and as far as I know all the other classes
based on ASN.1 structures do not override '=='. But I think it's safe to define and would be more intuitive if equality for such
objects would be defined on the DER level, i.e. two objects are equal if their encoding is equal.

I'll open new issues for these.

Also available in: Atom PDF