Feature #4896

Add newpad() support to Curses

Added by Eric Hodel almost 3 years ago. Updated almost 3 years ago.

[ruby-core:37206]
Status:Closed
Priority:Normal
Assignee:Shugo Maeda
Category:ext
Target version:2.0.0

Description

The ruby curses library lacks support for scrolling regions via newpad(). This patch adds support for newpad() as a subclass of Curses::Window.

May I apply it?

curses.c.pad.patch Magnifier - Adds Curses::Pad (5.95 KB) Eric Hodel, 06/18/2011 06:41 AM

Associated revisions

Revision 32576
Added by Shugo Maeda almost 3 years ago

  • ext/curses/curses.c: added the new class Curses::Pad, which supports scrolling. patch by Eric Hodel. [Feature #4896]

History

#1 Updated by Hiroshi Nakamura almost 3 years ago

  • Target version changed from 1.9.3 to 2.0.0

#2 Updated by Eric Hodel almost 3 years ago

Why was this moved to 1.9.x?

I have used this patch to write a browser-like tool and it seems to work OK.

Can we have this in 1.9.3?

#3 Updated by Hiroshi Nakamura almost 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to Shugo Maeda
  • Target version changed from 2.0.0 to 1.9.3

My bad, I though curses does not have a maintainer, so I moved this out from 1.9.3.
Shugo, please handle this.

1.9.3 feature is said to be freezed by Yugui, so it should be delayed to 1.9.4 in general. But all scheduled milestones are delaying so there might be a chance to be included in 1.9.3.

#4 Updated by Ryan Davis almost 3 years ago

I thought feature freeze was pushed back to end of June?

#5 Updated by Shugo Maeda almost 3 years ago

Hiroshi Nakamura wrote:

My bad, I though curses does not have a maintainer, so I moved this out from 1.9.3.
Shugo, please handle this.

1.9.3 feature is said to be freezed by Yugui, so it should be delayed to 1.9.4 in general. But all scheduled milestones are delaying so there might be a chance to be included in 1.9.3.

The patch looks good, but I can't decide it should be included in 1.9.3 or not.
I defer to Yugui's judgement.

#6 Updated by Yui NARUSE almost 3 years ago

  • Target version changed from 1.9.3 to 2.0.0

#7 Updated by Shugo Maeda almost 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32576.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/curses/curses.c: added the new class Curses::Pad, which supports scrolling. patch by Eric Hodel. [Feature #4896]

Also available in: Atom PDF