Project

General

Profile

Actions

Feature #4896

closed

Add newpad() support to Curses

Added by drbrain (Eric Hodel) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:37206]

Description

The ruby curses library lacks support for scrolling regions via newpad(). This patch adds support for newpad() as a subclass of Curses::Window.

May I apply it?


Files

curses.c.pad.patch (5.95 KB) curses.c.pad.patch Adds Curses::Pad drbrain (Eric Hodel), 06/18/2011 06:41 AM

Updated by nahi (Hiroshi Nakamura) over 10 years ago

  • Target version changed from 1.9.3 to 2.0.0

Updated by drbrain (Eric Hodel) over 10 years ago

Why was this moved to 1.9.x?

I have used this patch to write a browser-like tool and it seems to work OK.

Can we have this in 1.9.3?

Updated by nahi (Hiroshi Nakamura) over 10 years ago

  • Status changed from Open to Assigned
  • Assignee set to shugo (Shugo Maeda)
  • Target version changed from 2.0.0 to 1.9.3

My bad, I though curses does not have a maintainer, so I moved this out from 1.9.3.
Shugo, please handle this.

1.9.3 feature is said to be freezed by Yugui, so it should be delayed to 1.9.4 in general. But all scheduled milestones are delaying so there might be a chance to be included in 1.9.3.

Updated by zenspider (Ryan Davis) over 10 years ago

I thought feature freeze was pushed back to end of June?

Updated by shugo (Shugo Maeda) over 10 years ago

Hiroshi Nakamura wrote:

My bad, I though curses does not have a maintainer, so I moved this out from 1.9.3.
Shugo, please handle this.

1.9.3 feature is said to be freezed by Yugui, so it should be delayed to 1.9.4 in general. But all scheduled milestones are delaying so there might be a chance to be included in 1.9.3.

The patch looks good, but I can't decide it should be included in 1.9.3 or not.
I defer to Yugui's judgement.

Actions #6

Updated by naruse (Yui NARUSE) over 10 years ago

  • Target version changed from 1.9.3 to 2.0.0
Actions #7

Updated by shugo (Shugo Maeda) over 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32576.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/curses/curses.c: added the new class Curses::Pad, which supports scrolling. patch by Eric Hodel. [Feature #4896] [ruby-core:37206]
Actions

Also available in: Atom PDF