Feature #5480

remove GServer from stdlib

Added by Konstantin Haase over 3 years ago. Updated about 2 months ago.

[ruby-core:40313]
Status:Closed
Priority:Normal
Assignee:Hiroshi SHIBATA

Description

=begin
I propose removing the gserver library from Ruby's stdlib.

People should not use it for the following reasons:

  • It has no tests at all.
  • It does something completely different than it claims to do (the docs say it manages a thread pool, while in reality it creates a new thread for every incoming connection).
  • It is not maintained.

For instance, Net::HTTPServer (https://github.com/postmodern/net-http-server) uses GServer for concurrency. Removing GServer and just serving one request at a time improves performance drastically.
=end

Associated revisions

Revision 47187
Added by Hiroshi SHIBATA 11 months ago

  • lib/gserver.rb: removed unmaintained code. [Feature #5480]
  • lib/xmlrpc/httpserver.rb: ditto.

Revision 47187
Added by Hiroshi SHIBATA 11 months ago

  • lib/gserver.rb: removed unmaintained code. [Feature #5480]
  • lib/xmlrpc/httpserver.rb: ditto.

History

#1 Updated by Hiroshi Nakamura over 3 years ago

Agree for removal as the reasons Konstantin listed, but we might need migration period. How others think?
Do we add deprecation warning in 1.9.3 from now? (and remove GServer at 2.0.)

NB: We should remove lib/xmlrpc/httpserver.rb which utilizes GServer. lib/xmlrpc/httpserver.rb is described as 'obsolete' in 2005 (See ChangeLog.) And this dependency is the reason why gserver.rb is included in 1.8 IIRC.

#2 Updated by Koichi Sasada over 2 years ago

  • Category set to lib
  • Assignee set to Hiroshi Nakamura

I've forget this issue.
I assigned it to Nahi-san.

#3 Updated by Hiroshi SHIBATA 11 months ago

  • Assignee changed from Hiroshi Nakamura to Hiroshi SHIBATA
  • Status changed from Open to Assigned

#4 Updated by Hiroshi SHIBATA 11 months ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

Applied in changeset r47187.


  • lib/gserver.rb: removed unmaintained code. [Feature #5480]
  • lib/xmlrpc/httpserver.rb: ditto.

#5 Updated by Hal Brodigan about 2 months ago

For those that absolutely need to use GServer, it's also available on rubygems.

However, GServer isn't being maintained, so users should migrate to an alternative or write their own threaded TCP server as needed.

Also available in: Atom PDF