Bug #7065: Syslog::Logger should have a formatter

• Status: Closed
• Priority: Normal
• Assignee: knu (Akinori MUSHA)
• Target version: -
• ruby -v: ruby 2.0.0dev (2012-09-24 trunk 37026) [x86_64-darwin12.2.0]

[tenderlovemaking (Aaron Patterson)]

Hi, Syslog::Logger should have a formatter so that it can behave similar to the regular Logger class. I've attached a patch with tests to implement the formatter.

Thanks!

[bitsweat (Jeremy Daer)]

I tested this in my application. Works as expected.

[luislavena (Luis Lavena)]

How about moving ansi regexp as constant so regexp object doesn't get allocated on every formatter.call?

[Eregon (Benoit Daloze)]

luislavena (Luis Lavena) wrote:

How about moving ansi regexp as constant so regexp object doesn't get allocated on every formatter.call?

If I'm not mistaken this is unnecessary, as "static" (without #{...}) Regexps are created only once (because they are immutable):

class Formatter
  def clean
    /\e\[[0-9;]*m/
  end

  def clean2
    />#{'a'*2}</
  end
end

2.times { p Formatter.new.clean.object_id }
puts
2.times { p Formatter.new.clean2.object_id }

[luislavena (Luis Lavena)]

• Status changed from Open to Assigned

Eregon (Benoit Daloze) wrote:

If I'm not mistaken this is unnecessary, as "static" (without #{...}) Regexps are created only once (because they are immutable):

You're correct, I should stop responding to issues after 10pm.

[knu (Akinori MUSHA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r37039.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• ext/syslog/lib/syslog/logger.rb: add a formatter to the Syslog::Logger object. [Bug #7065]
• test/syslog/test_syslog_logger.rb: ditto.