Project

General

Profile

Actions

Bug #7482

closed

test_system_redirect_win(TestSystem) failure on Windows 8

Added by phasis68 (Heesob Park) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby -v: ruby 2.0.0dev (2012-11-29) [x64-mingw32]
Backport:
[ruby-core:50396]

Description

I found the following test failure on Windows 8.

test_system_redirect_win(TestSystem) [c:/work/snapshot-mg64/test/ruby/test_system.rb:123]:
[ruby-talk:258939].
expected but was
.

I think the test_system_redirect_win is a wrong test case.
the ping command is not the point of [ruby-talk:258939].
And the ping result may differ depending on the machine.

Updated by usa (Usaku NAKAMURA) over 9 years ago

Ah, I should check these Win8 tickets, but I have no time before the release
limit of preview 2.

Committers, please check the tickets and fix them (if you can) before the release...

Updated by usa (Usaku NAKAMURA) over 9 years ago

  • Status changed from Open to Assigned
  • Assignee set to usa (Usaku NAKAMURA)

Updated by usa (Usaku NAKAMURA) over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from usa (Usaku NAKAMURA) to kosaki (Motohiro KOSAKI)

I can't understand this test.
Kosaki-san, can you describe?

Updated by drbrain (Eric Hodel) over 9 years ago

Kosaki-san, can you check this issue?

Actions #5

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38956.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


test_system.rb: fix test

  • test/ruby/test_system.rb (TestSystem#test_system_redirect_win): fix
    meaningless test. [Bug #7482]

Updated by phasis68 (Heesob Park) over 9 years ago

As you can see in http://ci.rubyinstaller.org/job/ruby-trunk-x64-test-all/607/console,
This issues is not solved with changeset r38956.

  1. Failure:
    test_system_redirect_win(TestSystem) [C:/Users/Worker/Jenkins/workspace/ruby-trunk-x64-build/test/ruby/test_system.rb:144]:
    [ruby-talk:258939]
    out.txt:
    err.txt:
    "'"C:\Windows/system32/find.exe BFI3CHL671"' is not recognized as an internal or external command,\n"
    "operable program or batch file.\n"
    system(""%WINDIR%/system32/find.exe BFI3CHL671" input.txt > out.txt 2>err.txt").
    expected but was
    .

This failure is also occurred on Windows 8.

I'm not sure why you think the third case should be true.
Here is patch:
diff --git a/test_system.rb b/test_system.rb.new
index b877538..db19a3c 100644
--- a/test_system.rb
+++ b/test_system.rb.new
@@ -141,7 +141,7 @@ class TestSystem < Test::Unit::TestCase
cmd = ""%WINDIR%/system32/find.exe" "BFI3CHL671" input.txt > out.txt 2>err.txt"
assert_equal(true, system(cmd), message)
cmd = ""%WINDIR%/system32/find.exe BFI3CHL671" input.txt > out.txt 2>err.txt"

  •    assert_equal(true, system(cmd), message)
    
  •    assert_equal(false, system(cmd), message)
     end
    
    end
    end

Updated by luislavena (Luis Lavena) over 9 years ago

  • Category set to test
  • Status changed from Closed to Assigned
  • Assignee changed from kosaki (Motohiro KOSAKI) to nobu (Nobuyoshi Nakada)
  • Target version set to 2.0.0
  • % Done changed from 100 to 50

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 50 to 100
Actions

Also available in: Atom PDF