Project

General

Profile

Bug #7530

Concurrent loads fail with mutex errors

Added by Charles Nutter about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
ruby -v:
ruby 2.0.0dev (2012-12-01 trunk 38126) [x86_64-darwin11.4.2]
Backport:
[ruby-core:50645]

Description

I have no idea what's going on here.

jruby-1.7.0 ~/projects/vts-jruby $ cat bench_load_path.rb 
require 'benchmark'

FAKE_PATHS = ARGV[0].to_i || 100
THREADS = 8
ITERATIONS_PER_THREAD = 1000

FAKE_PATHS.times do |i|
  $:.unshift "foo#{i}"
end

$: << '.'

system 'touch __load_path_bench_script__.rb'
puts Benchmark.measure {
  @threads = THREADS.times.map do
    Thread.new {
      ITERATIONS_PER_THREAD.times do
        require '__load_path_bench_script__'
        $".pop
      end
    }
  end
  @threads.each { |t| t.join }
}
system 'rm __load_path_bench_script__.rb'

jruby-1.7.0 ~/projects/vts-jruby $ ruby-2.0.0 -rubygems bench_load_path.rb 100
/usr/local/lib/ruby/2.0.0/rubygems/custom_require.rb:36:in `require': wrong argument type false (expected mutex) (TypeError)
    from /usr/local/lib/ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:17:in `block (3 levels) in <main>'

jruby-1.7.0 ~/projects/vts-jruby $ ruby-2.0.0 --disable-gems bench_load_path.rb 100
bench_load_path.rb:18:in `require': wrong argument type false (expected mutex) (TypeError)
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:17:in `block (3 levels) in <main>'

With verbose on, I get this error and a bunch of circular require warnings, even though I'm not doing any circular requires here.

ruby-2.0.0-preview2 ~/projects/vts-jruby $ ruby -v bench_load_path.rb 
ruby 2.0.0dev (2012-12-01 trunk 38126) [x86_64-darwin11.4.2]
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36: warning: loading in progress, circular require considered harmful - /Users/headius/projects/vts-jruby/__load_path_bench_script__.rb
    from bench_load_path.rb:17:in `block (3 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
/Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require': Attempt to unlock a mutex which is locked by another thread (ThreadError)
    from /Users/headius/.rvm/rubies/ruby-2.0.0-preview2/lib/ruby/site_ruby/2.0.0/rubygems/custom_require.rb:36:in `require'
    from bench_load_path.rb:18:in `block (4 levels) in <main>'
    from bench_load_path.rb:17:in `times'
    from bench_load_path.rb:17:in `block (3 levels) in <main>'

Related issues

Related to Ruby trunk - Bug #10892: Deadlock in autoload Open
Related to Ruby trunk - Bug #12999: there still exist race conditions in require Closed

Associated revisions

Revision 38744
Added by glass almost 4 years ago

  • load.c (load_lock): fix not to delete thread shield twice.
    it may break the shield locked by another thread.
    [Bug #7530]

  • test/ruby/test_require.rb: a test for above.

Revision 38744
Added by glass almost 4 years ago

  • load.c (load_lock): fix not to delete thread shield twice.
    it may break the shield locked by another thread.
    [Bug #7530]

  • test/ruby/test_require.rb: a test for above.

Revision 38744
Added by glass almost 4 years ago

  • load.c (load_lock): fix not to delete thread shield twice.
    it may break the shield locked by another thread.
    [Bug #7530]

  • test/ruby/test_require.rb: a test for above.

Revision 38750
Added by glass almost 4 years ago

  • load.c (load_lock): if thread shield is destroyed and there is no waiting thread, insert new thread shield into load_table. [Bug #7530]

Revision 38750
Added by glass almost 4 years ago

  • load.c (load_lock): if thread shield is destroyed and there is no waiting thread, insert new thread shield into load_table. [Bug #7530]

Revision 38750
Added by glass almost 4 years ago

  • load.c (load_lock): if thread shield is destroyed and there is no waiting thread, insert new thread shield into load_table. [Bug #7530]

History

#1 Updated by Usaku NAKAMURA almost 4 years ago

  • Category set to core
  • Status changed from Open to Assigned
  • Assignee set to Motohiro KOSAKI
  • Target version set to 2.0.0

#2 [ruby-core:51078] Updated by Motohiro KOSAKI almost 4 years ago

  • Assignee changed from Motohiro KOSAKI to Nobuyoshi Nakada

When removing $".pop likes following, this issue never happen.
So, I suspect this is require and threadshield issue.


require 'benchmark'

FAKE_PATHS = ARGV[0].to_i || 100
THREADS = 2
ITERATIONS_PER_THREAD = 1000

FAKE_PATHS.times do |i|
  $:.unshift "foo#{i}"
end

$: << '.'

ITERATIONS_PER_THREAD.times {|i|
  system "touch __load_path_bench_script__#{i}.rb"
}

puts Benchmark.measure {
  @threads = THREADS.times.map do
    Thread.new {
      ITERATIONS_PER_THREAD.times do |i|
        require "__load_path_bench_script__#{i}"
      end
    }
  end
  @threads.each { |t| t.join }
}

ITERATIONS_PER_THREAD.times {|i|
  system "rm __load_path_bench_script__#{i}.rb"
}


#3 [ruby-core:51136] Updated by Nobuyoshi Nakada almost 4 years ago

  • Priority changed from Normal to 5

#4 [ruby-core:51309] Updated by Masaki Matsushita almost 4 years ago

Here is the minimal code:

THREADS = 2
ITERATIONS_PER_THREAD = 1000

system 'touch __load_path_bench_script__.rb'
THREADS.times.map {
  Thread.new do
    ITERATIONS_PER_THREAD.times do
      require_relative '__load_path_bench_script__'
      $".pop
    end
  end
}.each(&:join)
system 'rm __load_path_bench_script__.rb'

#5 [ruby-core:51312] Updated by Masaki Matsushita almost 4 years ago

  • Assignee changed from Nobuyoshi Nakada to Masaki Matsushita

#6 Updated by Anonymous almost 4 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38744.
Charles, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • load.c (load_lock): fix not to delete thread shield twice.
    it may break the shield locked by another thread.
    [Bug #7530]

  • test/ruby/test_require.rb: a test for above.

#7 Updated by Nobuyoshi Nakada over 1 year ago

  • Related to Bug #10892: Deadlock in autoload added

#8 [ruby-core:70198] Updated by Nobuyoshi Nakada over 1 year ago

  • Description updated (diff)

#9 Updated by Shugo Maeda 6 days ago

  • Related to Bug #12999: there still exist race conditions in require added

Also available in: Atom PDF